services/video_capture/service_manifest.json - Issue 2224103002: Package video capture skeleton as Mojo Shell Service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/video_capture/service_manifest.json

Issue 2224103002: Package video capture skeleton as Mojo Shell Service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@VideoMojoSkeleton2

Patch Set: mcasas' comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {

	2 "manifest_version": 1,

	3 "name": "mojo:video_capture",

	4 "display_name": "Video Capture",

	5 "capabilities": {

	6 "provided": {

	7 "all": ["*"]
	yzshen1 2016/08/12 17:46:50 I think we will need to restrict access to this se I think we will need to restrict access to this service because video capturing is a privileged service? Are you planning to do that in a future CL? chfremer 2016/08/12 18:32:27 By restricting access, do you mean offering differ Show quoted text On 2016/08/12 17:46:50, yzshen1 wrote: > I think we will need to restrict access to this service because video capturing > is a privileged service? Are you planning to do that in a future CL? By restricting access, do you mean offering different class-type entries in the provided section here or are there other mechanisms beyond this? If the former, then yes, I am going to add different entries for the different types of clients. yzshen1 2016/08/12 20:05:53 Okay. Thanks! Show quoted text On 2016/08/12 18:32:27, chfremer wrote: > On 2016/08/12 17:46:50, yzshen1 wrote: > > I think we will need to restrict access to this service because video > capturing > > is a privileged service? Are you planning to do that in a future CL? > > By restricting access, do you mean offering different class-type entries in the > provided section here or are there other mechanisms beyond this? > If the former, then yes, I am going to add different entries for the different > types of clients. Okay. Thanks!
	8 },

	9 "required": {

	10 "mojo:shell": { "classes": [ "shell:all_users" ] }

	11 }

	12 }

	13 }

OLD	NEW