services/video_capture/service_manifest.json - Issue 2224103002: Package video capture skeleton as Mojo Shell Service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/video_capture/service_manifest.json

Issue 2224103002: Package video capture skeleton as Mojo Shell Service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@VideoMojoSkeleton2

Patch Set: Fix for bots Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« services/video_capture/public/interfaces/video_capture_device.mojom ('K') | « services/video_capture/service_main.cc ('k') | services/video_capture/service_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "manifest_version": 1,

	3 "name": "mojo:video_capture",

	4 "display_name": "Video Capture",

	5 "capabilities": {

	6 "provided": {

	7 "all": ["*"]
	Ben Goodger (Google) 2016/08/15 22:56:48 Help me understand the interfaces you expect to bi Help me understand the interfaces you expect to bind from tests. Are some unsafe to be seen by renderers? By other specific process types? chfremer 2016/08/15 23:19:47 The service is supposed to have two types of clien Show quoted text On 2016/08/15 22:56:48, Ben Goodger (Google) wrote: > Help me understand the interfaces you expect to bind from tests. > > Are some unsafe to be seen by renderers? By other specific process types? The service is supposed to have two types of clients. The first client is a component called VideoCaptureManager, which lives in the Browser process and whose responsibility it is to distribute access to (and video frames from) the video capture devices to potentially multiple clients. These clients typically live in the renderers. The second type of client is a component test for the service. There may or may not be some interfaces that are exclusive to the testing client in the end. At this stage, we only have the testing client, so I am not (yet) distinguishing different classes of provided-interfaces. Is there anything I need to do to hide this service from renderers?
	8 },

	9 "required": {

	10 "mojo:shell": { "classes": [ "shell:all_users" ] }

	11 }

	12 }

	13 }

OLD	NEW