Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 2224093002: Revert of Adding SwiftShader to the DEPS file (Closed)

Created:
4 years, 4 months ago by stevenjb
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Shannon Woods
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding SwiftShader to the DEPS file (patchset #2 id:20001 of https://codereview.chromium.org/2168143003/ ) Reason for revert: Failures on chrome os and elsewhere. Example Chrome OS failure: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-cheets-tot-chrome-pfq-cheets-informational/builds/719 Linux failure: https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%29/builds/6246 Original issue's description: > Adding SwiftShader to the DEPS file > > The SwiftShader library has recently been made open source > and can now be pulled with the Chromium checkout. The size > of the SwiftShader library is roughly 162 Mb, currently. > Note that this will eventually allow us to remove MESA, > which takes approximately 66 Mb, so the net gain should be > under 100Mb in total. > > Pulling SwiftShader along with Chromium will allow bots to > build SwiftShader, perform tests with the SwiftShader > library and have quick turnaround time when issues are > found. > > This will not change the state of SwiftShader as a > component in Chrome and it will not be shipped with Chrome, > only downloaded as a component on demand. > > Also note that this cl does not enable building > SwiftShader, it only allows the SwiftShader library to be > pulled, to make sure that everyone agrees with this first > step. > > BUG=630728 > > Committed: https://crrev.com/7d27602ad344f04dcb94ce5ead7950a0cfc1cd02 > Cr-Commit-Position: refs/heads/master@{#410359} TBR=phajdan.jr@chromium.org,capn@chromium.org,dglazkov@chromium.org,jam@chromium.org,kbr@chromium.org,phajdan@google.com,sky@chromium.org,sugoi@google.com,tandrii@chromium.org,sugoi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630728 Committed: https://crrev.com/86cd5c0e5b8f427d600fce40b88749d8664e9ef6 Cr-Commit-Position: refs/heads/master@{#410404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M DEPS View 3 chunks +0 lines, -8 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
stevenjb
Created Revert of Adding SwiftShader to the DEPS file
4 years, 4 months ago (2016-08-08 19:37:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224093002/1
4 years, 4 months ago (2016-08-08 19:38:35 UTC) #3
hshi1
lgtm
4 years, 4 months ago (2016-08-08 19:38:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 19:39:27 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 19:41:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86cd5c0e5b8f427d600fce40b88749d8664e9ef6
Cr-Commit-Position: refs/heads/master@{#410404}

Powered by Google App Engine
This is Rietveld 408576698