Chromium Code Reviews
DescriptionRevert of Adding SwiftShader to the DEPS file (patchset #2 id:20001 of https://codereview.chromium.org/2168143003/ )
Reason for revert:
Failures on chrome os and elsewhere. Example Chrome OS failure:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-cheets-tot-chrome-pfq-cheets-informational/builds/719
Linux failure:
https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%29/builds/6246
Original issue's description:
> Adding SwiftShader to the DEPS file
>
> The SwiftShader library has recently been made open source
> and can now be pulled with the Chromium checkout. The size
> of the SwiftShader library is roughly 162 Mb, currently.
> Note that this will eventually allow us to remove MESA,
> which takes approximately 66 Mb, so the net gain should be
> under 100Mb in total.
>
> Pulling SwiftShader along with Chromium will allow bots to
> build SwiftShader, perform tests with the SwiftShader
> library and have quick turnaround time when issues are
> found.
>
> This will not change the state of SwiftShader as a
> component in Chrome and it will not be shipped with Chrome,
> only downloaded as a component on demand.
>
> Also note that this cl does not enable building
> SwiftShader, it only allows the SwiftShader library to be
> pulled, to make sure that everyone agrees with this first
> step.
>
> BUG=630728
>
> Committed: https://crrev.com/7d27602ad344f04dcb94ce5ead7950a0cfc1cd02
> Cr-Commit-Position: refs/heads/master@{#410359}
TBR=phajdan.jr@chromium.org,capn@chromium.org,dglazkov@chromium.org,jam@chromium.org,kbr@chromium.org,phajdan@google.com,sky@chromium.org,sugoi@google.com,tandrii@chromium.org,sugoi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630728
Committed: https://crrev.com/86cd5c0e5b8f427d600fce40b88749d8664e9ef6
Cr-Commit-Position: refs/heads/master@{#410404}
Patch Set 1 #Messages
Total messages: 9 (4 generated)
|