Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2224073003: On asan/win bots building with goma, don't accidentally emit DWARF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index cf51896225d1dfae31600dc8a573a057b773a17b..3768cb93553872974ffcf685544b21f43525efc9 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -231,6 +231,12 @@ config("common_sanitizer_flags") {
if (using_sanitizer) {
assert(is_clang, "sanitizers only supported with clang")
cflags += [ "-gline-tables-only" ]
+ if (is_win) {
+ # Just -gline-tables-only currently causes clang-cl to emit debug info
+ # in DWARF format.
+ # TODO(thakis): Remove this once we have a clang at LLVM r278139+
+ cflags += [ "/Z7" ]
+ }
}
# Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698