Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Issue 2224073003: On asan/win bots building with goma, don't accidentally emit DWARF (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

On asan/win bots building with goma, don't accidentally emit DWARF This happens to work around a bug we don't yet understand, but seems like a good change in its own right too. BUG=635715 R=rnk@chromium.org Committed: https://crrev.com/314120a8cfd5df331d825566d25db1ba1a1983fe Cr-Commit-Position: refs/heads/master@{#410785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/config/sanitizers/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
4 years, 4 months ago (2016-08-09 18:13:48 UTC) #3
Nico
4 years, 4 months ago (2016-08-09 18:13:49 UTC) #4
Reid Kleckner
lgtm
4 years, 4 months ago (2016-08-09 18:23:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224073003/1
4 years, 4 months ago (2016-08-09 18:27:40 UTC) #10
Nico
Committed patchset #1 (id:1) to pending queue manually as a83eab526859aa4d9d8655e9edaff86e04694019 (presubmit successful).
4 years, 4 months ago (2016-08-09 20:04:15 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/314120a8cfd5df331d825566d25db1ba1a1983fe Cr-Commit-Position: refs/heads/master@{#410785}
4 years, 4 months ago (2016-08-09 20:05:22 UTC) #14
Nico
4 years, 3 months ago (2016-08-25 15:28:15 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2281583002/ by thakis@chromium.org.

The reason for reverting is: We have now rolled past r278139 and this shouldn't
be necessary any more..

Powered by Google App Engine
This is Rietveld 408576698