Remove MsgBox()/Alert() from CJS_EmbedObj.

Remove MsgBox()/Alert() from CJS_EmbedObj.

They're only related to the |app| object, not all embed's.
Alert() itself unused.

Committed: https://pdfium.googlesource.com/pdfium/+/e1e7bd037538c6b31537fc0e3e01c508dab68132

[Tom Sepez, 2016-08-08 19:11:58]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 19:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-08 19:12:45]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-08-08 19:12:46]

Dan, more cleanup.

[dsinclair, 2016-08-08 19:15:11]

lgtm w/ question.

https://codereview.chromium.org/2224073002/diff/1/fpdfsdk/javascript/JS_Objec...
File fpdfsdk/javascript/JS_Object.cpp (left):

https://codereview.chromium.org/2224073002/diff/1/fpdfsdk/javascript/JS_Objec...
fpdfsdk/javascript/JS_Object.cpp:34: CJS_Object::Alert(pContext, swMsg);
Is CJS_Object::Alert called from else where or can it also be removed?

[Tom Sepez, 2016-08-08 19:17:29]

Description was changed from

==========
Remove MsgBox()/Alert() from CJS_EmbedObj.

They're only related to the |app| object, not all embed's
==========

to

==========
Remove MsgBox()/Alert() from CJS_EmbedObj.

They're only related to the |app| object, not all embed's.
Alert() itself unused.
==========

[Tom Sepez, 2016-08-08 19:21:31]

https://codereview.chromium.org/2224073002/diff/1/fpdfsdk/javascript/JS_Objec...
File fpdfsdk/javascript/JS_Object.cpp (left):

https://codereview.chromium.org/2224073002/diff/1/fpdfsdk/javascript/JS_Objec...
fpdfsdk/javascript/JS_Object.cpp:34: CJS_Object::Alert(pContext, swMsg);
On 2016/08/08 19:15:11, dsinclair wrote:
> Is CJS_Object::Alert called from else where or can it also be removed?

fpdfsdk/javascript/PublicMethods.cpp:916 for example.

[Tom Sepez, 2016-08-08 19:27:46]

But we can make it a private function.  PTAnotherL.

[Tom Sepez, 2016-08-08 19:28:32]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 19:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-08 19:29:59]

lgtm

[commit-bot: I haz the power, 2016-08-08 19:40:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:40:30]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-08 20:02:57]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-08-08 20:03:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:03:19]

Description was changed from

==========
Remove MsgBox()/Alert() from CJS_EmbedObj.

They're only related to the |app| object, not all embed's.
Alert() itself unused.
==========

to

==========
Remove MsgBox()/Alert() from CJS_EmbedObj.

They're only related to the |app| object, not all embed's.
Alert() itself unused.

Committed:
https://pdfium.googlesource.com/pdfium/+/e1e7bd037538c6b31537fc0e3e01c508dab6...
==========

[commit-bot: I haz the power, 2016-08-08 20:03:20]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e1e7bd037538c6b31537fc0e3e01c508dab6...