content/browser/ppapi_plugin_process_host.cc - Issue 2224063002: Use persistent memory for receiving metrics from sub-processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/ppapi_plugin_process_host.cc

Issue 2224063002: Use persistent memory for receiving metrics from sub-processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments by Alexei Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_child_process_host_impl.h ('K') | « content/browser/gpu/gpu_process_host.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/ppapi_plugin_process_host.cc

diff --git a/content/browser/ppapi_plugin_process_host.cc b/content/browser/ppapi_plugin_process_host.cc

index 19d434485e9ccef46093d1e6ac4db6f951192dc6..725c1e6431bd2f33fa0679620eb071a9712c4e7e 100644

--- a/content/browser/ppapi_plugin_process_host.cc

+++ b/content/browser/ppapi_plugin_process_host.cc

@@ -330,7 +330,7 @@ PpapiPluginProcessHost::PpapiPluginProcessHost(

permissions_ = ppapi::PpapiPermissions::GetForCommandLine(base_permissions);

process_.reset(new BrowserChildProcessHostImpl(

- PROCESS_TYPE_PPAPI_PLUGIN, this, mojo_child_token_));

+ PROCESS_TYPE_PPAPI_PLUGIN, this, mojo_child_token_, 0, nullptr));

host_impl_.reset(new BrowserPpapiHostImpl(this, permissions_, info.name,

info.path, profile_data_directory,

@@ -355,7 +355,7 @@ PpapiPluginProcessHost::PpapiPluginProcessHost()

: is_broker_(true),

mojo_child_token_(mojo::edk::GenerateRandomToken()) {

process_.reset(new BrowserChildProcessHostImpl(

- PROCESS_TYPE_PPAPI_BROKER, this, mojo_child_token_));

+ PROCESS_TYPE_PPAPI_BROKER, this, mojo_child_token_, 0, nullptr));

ppapi::PpapiPermissions permissions; // No permissions.

// The plugin name, path and profile data directory shouldn't be needed for