Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2224053002: Reland "Refactor download image-MIME-type-detection code." (Closed)

Created:
4 years, 4 months ago by Daniel Erat
Modified:
4 years, 4 months ago
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Refactor download image-MIME-type-detection code." Refactor duplicated image-MIME-type-detection code from DownloadCommands and DownloadItemNotification into a new DownloadItemModel::HasSupportedImageMimeType() method. (Relanding since original commit 759969db accidentally pulled in another change.) BUG=605805 TBR=rdsmith@chromium.org,svaldez@chromium.org Committed: https://crrev.com/f849948b4cda2211ef24f1e92916a2cd9f442430 Cr-Commit-Position: refs/heads/master@{#410428}

Patch Set 1 #

Patch Set 2 : add download_item_notification.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -32 lines) Patch
M chrome/browser/download/download_commands.cc View 2 chunks +3 lines, -16 lines 0 comments Download
M chrome/browser/download/download_item_model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/download/notification/download_item_notification.cc View 1 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Daniel Erat
(same as what you reviewed before)
4 years, 4 months ago (2016-08-08 19:12:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224053002/20001
4 years, 4 months ago (2016-08-08 19:12:48 UTC) #5
svaldez
lgtm
4 years, 4 months ago (2016-08-08 19:16:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-08 20:21:23 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:23:40 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f849948b4cda2211ef24f1e92916a2cd9f442430
Cr-Commit-Position: refs/heads/master@{#410428}

Powered by Google App Engine
This is Rietveld 408576698