Teach SecurityStateModel about subresources with cert errors

Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171, 636986
Committed: https://crrev.com/61ab9d4706f6887539b9097bdbbc40ec6e671c85
Cr-Commit-Position: refs/heads/master@{#411520}

[estark, 2016-08-09 04:48:58]

Description was changed from

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspectie.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

This CL is based on top of https://codereview.chromium.org/2224193003/.

BUG=634171
==========

to

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

This CL is based on top of https://codereview.chromium.org/2224193003/.

BUG=634171
==========

[estark, 2016-08-09 18:21:46]

Description was changed from

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

This CL is based on top of https://codereview.chromium.org/2224193003/.

BUG=634171
==========

to

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
 Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
 (this CL)
#3: https://codereview.chromium.org/2225213004/
 Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171
==========

[estark, 2016-08-09 18:22:32]

Description was changed from

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
 Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
 (this CL)
#3: https://codereview.chromium.org/2225213004/
 Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171
==========

to

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171
==========

[estark, 2016-08-11 16:02:52]

Description was changed from

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171
==========

to

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171,636986
==========

[estark, 2016-08-11 16:05:09]

estark@chromium.org changed reviewers:
+ jam@chromium.org

[estark, 2016-08-11 16:05:10]

jam, sending you a series of CLs to separate mixed content plumbing from
subresources-with-cert-errors plumbing, which is what caused the test flakes you
ran into in https://codereview.chromium.org/2191113002/.

Could you please take a look? This is #2/4; the first is an enum rename that I
sent to felt@.

[jam, 2016-08-11 19:37:49]

lgtm

[estark, 2016-08-12 00:52:06]

The CQ bit was checked by estark@chromium.org

[estark, 2016-08-12 00:52:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2224023003/#ps120001
(title: "rebase fixup")

[commit-bot: I haz the power, 2016-08-12 00:52:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 02:09:13]

Description was changed from

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171,636986
==========

to

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171,636986
==========

[commit-bot: I haz the power, 2016-08-12 02:09:14]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-12 02:12:18]

Description was changed from

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171,636986
==========

to

==========
Teach SecurityStateModel about subresources with cert errors

This is the second in a series of CLs to create dedicated plumbing for
subresources with certificate errors, instead of treating them like
mixed content from the browser's perspective.

This CL adds flags for subresources with cert errors to
SecurityStateModel and SSLStatus. ChromeSecurityStateModelClient sets
these flags on the VisibleSecurityState based on the NavigationEntry's
SSLStatus, and SecurityStateModel downgrades the security level
appropriately.

Nothing yet sets the flags on the SSLStatus.

#1: https://codereview.chromium.org/2224193003/
  Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values
#2: https://codereview.chromium.org/2224023003/
  (this CL)
#3: https://codereview.chromium.org/2225213004/
  Teach SSLHostStateDelegate about subresources with cert errors
#4: https://codereview.chromium.org/2226363002/
  Track subresources with cert errors separately from mixed content

BUG=634171,636986

Committed: https://crrev.com/61ab9d4706f6887539b9097bdbbc40ec6e671c85
Cr-Commit-Position: refs/heads/master@{#411520}
==========

[commit-bot: I haz the power, 2016-08-12 02:12:19]

Patchset 7 (id:??) landed as
https://crrev.com/61ab9d4706f6887539b9097bdbbc40ec6e671c85
Cr-Commit-Position: refs/heads/master@{#411520}