Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: net/quic/core/quic_framer_test.cc

Issue 2223993002: Remove v33 connection id public flags hack as Maglev has rolled out. Protected by quic_remove_v33_h… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129001103
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_framer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_framer_test.cc
diff --git a/net/quic/core/quic_framer_test.cc b/net/quic/core/quic_framer_test.cc
index 205ea06b1dd198fd3954202bc7261181696e60dd..75d362844bc33474f4d5f89750759da1a32255eb 100644
--- a/net/quic/core/quic_framer_test.cc
+++ b/net/quic/core/quic_framer_test.cc
@@ -4824,7 +4824,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithVersionFlag) {
unsigned char packet[] = {
// public flags (version, 8 byte connection_id)
static_cast<unsigned char>(
- framer_.version() > QUIC_VERSION_32 ? 0x3D : 0x3D),
+ (FLAGS_quic_remove_v33_hacks &&
+ framer_.version() > QUIC_VERSION_32) ? 0x39 : 0x3D),
// connection_id
0x10, 0x32, 0x54, 0x76, 0x98, 0xBA, 0xDC, 0xFE,
// version tag
@@ -4845,7 +4846,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithVersionFlag) {
};
unsigned char packet_34[] = {
// public flags (version, 8 byte connection_id)
- 0x3D,
+ static_cast<unsigned char>(
+ FLAGS_quic_remove_v33_hacks ? 0x39 : 0x3D),
// connection_id
0x10, 0x32, 0x54, 0x76, 0x98, 0xBA, 0xDC, 0xFE,
// version tag
@@ -4977,7 +4979,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithBothVersionAndMultipathFlag) {
unsigned char packet[] = {
// public flags (8 byte connection_id)
static_cast<unsigned char>(
- framer_.version() > QUIC_VERSION_32 ? 0x7D : 0x7D),
+ (FLAGS_quic_remove_v33_hacks &&
+ framer_.version() > QUIC_VERSION_32) ? 0x79 : 0x7D),
// connection_id
0x10, 0x32, 0x54, 0x76,
0x98, 0xBA, 0xDC, 0xFE,
@@ -5005,7 +5008,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithBothVersionAndMultipathFlag) {
};
unsigned char packet_34[] = {
// public flags (8 byte connection_id)
- 0x7D,
+ static_cast<unsigned char>(
+ FLAGS_quic_remove_v33_hacks ? 0x79 : 0x7D),
// connection_id
0x10, 0x32, 0x54, 0x76,
0x98, 0xBA, 0xDC, 0xFE,
« no previous file with comments | « net/quic/core/quic_framer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698