net/quic/core/quic_sent_packet_manager.h - Issue 2223983002: Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_sent_packet_manager.h

Issue 2223983002: Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/quic_sent_packet_manager.h

diff --git a/net/quic/core/quic_sent_packet_manager.h b/net/quic/core/quic_sent_packet_manager.h

index a875bc9f1e0dd8b9f632e2a91b343cd55942d27e..d2beca60173b53087841f0b2d8623192dcc9ea2f 100644

--- a/net/quic/core/quic_sent_packet_manager.h

+++ b/net/quic/core/quic_sent_packet_manager.h

@@ -15,6 +15,7 @@

#include "base/macros.h"

#include "net/base/linked_hash_map.h"

+#include "net/quic/core/congestion_control/general_loss_algorithm.h"

#include "net/quic/core/congestion_control/loss_detection_interface.h"

#include "net/quic/core/congestion_control/pacing_sender.h"

#include "net/quic/core/congestion_control/rtt_stats.h"

@@ -343,7 +344,9 @@ class NET_EXPORT_PRIVATE QuicSentPacketManager

const QuicPacketCount initial_congestion_window_;

RttStats rtt_stats_;

std::unique_ptr<SendAlgorithmInterface> send_algorithm_;

- std::unique_ptr<LossDetectionInterface> loss_algorithm_;

+ // Not owned. Always points to |general_loss_algorithm_| outside of tests.

+ LossDetectionInterface* loss_algorithm_;

+ GeneralLossAlgorithm general_loss_algorithm_;

bool n_connection_simulation_;

// Receiver side buffer in bytes.

« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | net/quic/core/quic_sent_packet_manager.cc » ('j') | no next file with comments »