telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py - Issue 2223963003: Add trace config file for Chrome on CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

Issue 2223963003: Add trace config file for Chrome on CrOS (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Added trace config file for Chrome on CrOS Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/core/tracing_controller_unittest.py ('k') | telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

index baed53ca1ca7a1e3b3d121a9e48e0c7d4866aa2a..80ef7ec61793aaa42bb6a438eef4a41b749a8b05 100644

--- a/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

@@ -75,6 +75,11 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

not self.browser_options.gaia_login):

args.append('--disable-gaia-services')

+ trace_config_file = (self.platform_backend.tracing_controller_backend

+ .GetChromeTraceConfigFile())

+ if trace_config_file:

+ args.append('--trace-config-file=%s' % trace_config_file)

return args

@property

@@ -108,6 +113,7 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

'org.chromium.SessionManagerInterface.EnableChromeTesting',

'boolean:true',

'array:string:"%s"' % ','.join(startup_args)]

+ logging.info('Starting Chrome %s', args)

self._cri.RunCmdOnDevice(args)

if not self._cri.local: