Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2223963002: Revert of Add per-section clearing and dismissed suggestions to snippets-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
index 70752b421c8a03c2c7585e6c49f1fd6d2daf912e..85457d2d8d568928e35f897e412e3415de495180 100644
--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
@@ -61,7 +61,6 @@
CategoryStatus BookmarkSuggestionsProvider::GetCategoryStatus(
Category category) {
- DCHECK_EQ(category, provided_category_);
return category_status_;
}
@@ -78,24 +77,12 @@
FROM_HERE, base::Bind(callback, suggestion_id, gfx::Image()));
}
-void BookmarkSuggestionsProvider::ClearCachedSuggestionsForDebugging(
- Category category) {
- DCHECK_EQ(category, provided_category_);
+void BookmarkSuggestionsProvider::ClearCachedSuggestionsForDebugging() {
// Ignored.
}
-std::vector<ContentSuggestion>
-BookmarkSuggestionsProvider::GetDismissedSuggestionsForDebugging(
- Category category) {
- DCHECK_EQ(category, provided_category_);
- // TODO(pke): Implement when discarded suggestions are supported.
- return std::vector<ContentSuggestion>();
-}
-
-void BookmarkSuggestionsProvider::ClearDismissedSuggestionsForDebugging(
- Category category) {
- DCHECK_EQ(category, provided_category_);
- // TODO(pke): Implement when discarded suggestions are supported.
+void BookmarkSuggestionsProvider::ClearDismissedSuggestionsForDebugging() {
+ // TODO(jkrcal): Implement when discarded suggestions are supported.
}
void BookmarkSuggestionsProvider::BookmarkModelLoaded(

Powered by Google App Engine
This is Rietveld 408576698