Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2223933002: Remove SK_SUPPORT_LEGACY_DATA_FACTORIES. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_SUPPORT_LEGACY_DATA_FACTORIES. The code protected by this flag is no longer used. Remove the flag and code. This also removes SK_SUPPORT_LEGACY_TYPEFACE_PTR from Android, as it is no longer needed. TBR=reed Only removes already guarded API. Committed: https://skia.googlesource.com/skia/+/f95388da1a0be3f5e510225ddc07e09928f3b1c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkData.h View 3 chunks +0 lines, -39 lines 0 comments Download
M public.bzl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
bungeman-skia
4 years, 4 months ago (2016-08-08 14:44:53 UTC) #6
mtklein
lgtm
4 years, 4 months ago (2016-08-08 14:48:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223933002/1
4 years, 4 months ago (2016-08-08 14:50:51 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:09:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f95388da1a0be3f5e510225ddc07e09928f3b1c9

Powered by Google App Engine
This is Rietveld 408576698