Add an API for setting the sticky error

Add an API for setting the sticky error

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/800b1352ce2f333bea780d2bf9f6bad854e146dd

[Cutch, 2016-08-08 14:46:21]

Description was changed from

==========
Add an API for setting the sticky error

BUG=
==========

to

==========
Add an API for setting the sticky error

BUG=
==========

[Cutch, 2016-08-08 14:46:21]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[siva, 2016-08-08 17:53:45]

lgtm

https://codereview.chromium.org/2223913002/diff/40001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2223913002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1456: CHECK_ISOLATE(isolate);
Probably better to create a scope here as we will be creating a handle below
when Api::UnwrapErrorHandle is called. If this function is called too many times
we might end up with handles in the top most scope (kind of a leak).

DARTSCOPE(Thread::Current());
Isolate* I = T->isolate();

https://codereview.chromium.org/2223913002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1466: Api::UnwrapErrorHandle(thread->zone(),
error).raw());
you could use Z here instead of thread->zone() to be consistent with the rest of
the file.

[Cutch, 2016-08-08 19:14:30]

https://codereview.chromium.org/2223913002/diff/40001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2223913002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1456: CHECK_ISOLATE(isolate);
On 2016/08/08 17:53:45, siva wrote:
> Probably better to create a scope here as we will be creating a handle below
> when Api::UnwrapErrorHandle is called. If this function is called too many
times
> we might end up with handles in the top most scope (kind of a leak).
> 
> DARTSCOPE(Thread::Current());
> Isolate* I = T->isolate();

Done.

https://codereview.chromium.org/2223913002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:1466: Api::UnwrapErrorHandle(thread->zone(),
error).raw());
On 2016/08/08 17:53:45, siva wrote:
> you could use Z here instead of thread->zone() to be consistent with the rest
of
> the file.

Done.

[Cutch, 2016-08-08 19:14:40]

Description was changed from

==========
Add an API for setting the sticky error

BUG=
==========

to

==========
Add an API for setting the sticky error

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/800b1352ce2f333bea780d2bf9f6bad854e146dd
==========

[Cutch, 2016-08-08 19:14:41]

Committed patchset #4 (id:60001) manually as
800b1352ce2f333bea780d2bf9f6bad854e146dd (presubmit successful).