Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2223873002: [turbofan] Assign proper types to Parameter nodes. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Assign proper types to Parameter nodes. R=epertoso@chromium.org Committed: https://crrev.com/3f3bacc31931063e010d7c99cb8106f1982e0d7e Cr-Commit-Position: refs/heads/master@{#40695}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE and fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -9 lines) Patch
M src/compiler/pipeline.cc View 1 2 2 chunks +14 lines, -2 lines 0 comments Download
M src/compiler/typer.h View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 2 3 chunks +31 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-08 13:14:29 UTC) #1
Benedikt Meurer
Hey Enrico, Now with green bots. Please take a look. Thanks, Benedikt
4 years, 1 month ago (2016-11-02 09:09:24 UTC) #12
epertoso
lgtm.
4 years, 1 month ago (2016-11-02 09:27:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223873002/40001
4 years, 1 month ago (2016-11-02 09:30:41 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 09:33:36 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:08 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f3bacc31931063e010d7c99cb8106f1982e0d7e
Cr-Commit-Position: refs/heads/master@{#40695}

Powered by Google App Engine
This is Rietveld 408576698