Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 222383002: Move UserActivityDetector from ash/wm/ to ui/wm/core/. (Closed)

Created:
6 years, 8 months ago by Daniel Erat
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org, James Cook
Visibility:
Public.

Description

Move UserActivityDetector from ash/wm/ to ui/wm/core/. This code is dependent on aura but not on ash. It'd be useful in app_shell, which doesn't use ash. BUG=354711 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261404

Patch Set 1 #

Patch Set 2 : remove an unneeded include #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -569 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/shell.h View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/shell.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/user_activity_notifier.h View 1 chunk +7 lines, -6 lines 2 comments Download
M ash/system/chromeos/power/user_activity_notifier.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
D ash/wm/user_activity_detector.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ash/wm/user_activity_detector.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D ash/wm/user_activity_detector_unittest.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D ash/wm/user_activity_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/display_power_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/idle_detector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/idle_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/session_length_limiter.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/session_length_limiter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/idle_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/wm/core/user_activity_detector.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/wm/core/user_activity_detector.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/wm/core/user_activity_detector_unittest.cc View 11 chunks +12 lines, -38 lines 0 comments Download
A + ui/wm/core/user_activity_observer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/wm/wm.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Daniel Erat
https://codereview.chromium.org/222383002/diff/10035/ash/system/chromeos/power/user_activity_notifier.h File ash/system/chromeos/power/user_activity_notifier.h (right): https://codereview.chromium.org/222383002/diff/10035/ash/system/chromeos/power/user_activity_notifier.h#newcode21 ash/system/chromeos/power/user_activity_notifier.h:21: class UserActivityNotifier : public ::wm::UserActivityObserver { i think that ...
6 years, 8 months ago (2014-04-02 16:03:21 UTC) #1
sky
LGTM https://codereview.chromium.org/222383002/diff/10035/ash/system/chromeos/power/user_activity_notifier.h File ash/system/chromeos/power/user_activity_notifier.h (right): https://codereview.chromium.org/222383002/diff/10035/ash/system/chromeos/power/user_activity_notifier.h#newcode21 ash/system/chromeos/power/user_activity_notifier.h:21: class UserActivityNotifier : public ::wm::UserActivityObserver { On 2014/04/02 ...
6 years, 8 months ago (2014-04-02 17:57:11 UTC) #2
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 8 months ago (2014-04-02 18:26:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/222383002/10035
6 years, 8 months ago (2014-04-02 18:27:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 03:13:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-03 03:13:11 UTC) #6
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 8 months ago (2014-04-03 04:11:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/222383002/10035
6 years, 8 months ago (2014-04-03 04:15:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 08:32:36 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 08:32:37 UTC) #10
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 8 months ago (2014-04-03 12:34:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/222383002/10035
6 years, 8 months ago (2014-04-03 12:34:50 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 14:59:07 UTC) #13
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 14:59:08 UTC) #14
Daniel Erat
On 2014/04/03 14:59:08, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
6 years, 8 months ago (2014-04-03 14:59:40 UTC) #15
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 8 months ago (2014-04-03 14:59:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/222383002/10035
6 years, 8 months ago (2014-04-03 15:02:23 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:11:54 UTC) #18
Message was sent while issue was closed.
Change committed as 261404

Powered by Google App Engine
This is Rietveld 408576698