Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2223823002: Use Networking task runner for FrameLoader::checkTimerFired (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Networking task runner for FrameLoader::checkTimerFired I don't think this task is explicitly speced, but it would make sense to use the networking task runner (which corresponds to the loading task runner in the current implementation). BUG=624696 Committed: https://crrev.com/63ab66a88765cce8f4434d07885185e430772697 Cr-Commit-Position: refs/heads/master@{#410591}

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-08 11:34:40 UTC) #2
tzik
lgtm
4 years, 4 months ago (2016-08-08 12:42:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223823002/1
4 years, 4 months ago (2016-08-08 13:38:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/108198)
4 years, 4 months ago (2016-08-08 13:47:00 UTC) #7
Sami
lgtm
4 years, 4 months ago (2016-08-08 14:52:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223823002/20001
4 years, 4 months ago (2016-08-09 03:45:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 05:53:01 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 05:55:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63ab66a88765cce8f4434d07885185e430772697
Cr-Commit-Position: refs/heads/master@{#410591}

Powered by Google App Engine
This is Rietveld 408576698