Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2223803002: X87: Use Variable::binding_needs_init() to determine hole initialization. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Use Variable::binding_needs_init() to determine hole initialization. port 6768456db513936cb19c8cdc657a7cd6122584a9 (r38395) original commit message: The old code was using VariableMode, but that signal is both over-pessimistic (some CONST and LET variables need no hole-initialization) and inconsistent with other uses of the InitializationFlag enum (such as %LoadLookupSlot). This changes no observable behavior, but removes unnecessary hole initialization and hole checks in a few places, including block-scoped function declarations, super property lookups, and new.target. BUG= Committed: https://crrev.com/759a06fca37a21dd62a21fbad602c3fb874c495c Cr-Commit-Position: refs/heads/master@{#38468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -43 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 7 chunks +27 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-08 09:38:30 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-09 02:36:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223803002/1
4 years, 4 months ago (2016-08-09 03:09:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 06:49:17 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 06:53:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/759a06fca37a21dd62a21fbad602c3fb874c495c
Cr-Commit-Position: refs/heads/master@{#38468}

Powered by Google App Engine
This is Rietveld 408576698