chrome/browser/ui/views/frame/immersive_mode_controller_ash.h - Issue 22238003: Keep the top-of-window views revealed when clicking on the top-of-window views with a bubble open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

Issue 22238003: Keep the top-of-window views revealed when clicking on the top-of-window views with a bubble open (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc » ('j') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

index 8ba1f2ae6c1f686c2ab15455b6b1409620dd05fa..b2d452a304823210138b5032f341bb41dbab358b 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

@@ -133,6 +133,10 @@ class ImmersiveModeControllerAsh : public ImmersiveModeController,

REVEALED, // All views showing, y = 0.

SLIDING_CLOSED, // All views showing, y animating from 0 to -height.

};

+ enum RevealWhileClosing {

James Cook 2013/08/06 23:32:42 Document what these mean. Also, I find the name a

+ REVEAL_WHILE_CLOSING_YES,

+ REVEAL_WHILE_CLOSING_NO

+ };

enum TabIndicatorVisibility {

TAB_INDICATORS_FORCE_HIDE,

TAB_INDICATORS_HIDE,

@@ -156,7 +160,8 @@ class ImmersiveModeControllerAsh : public ImmersiveModeController,

// Updates |located_event_revealed_lock_| based on the current mouse state and

// the current touch state.

// |event| is NULL if the source event is not known.

- void UpdateLocatedEventRevealedLock(ui::LocatedEvent* event);

+ void UpdateLocatedEventRevealedLock(ui::LocatedEvent* event,

+ RevealWhileClosing reveal_while_closing);

// Acquires |located_event_revealed_lock_| if it is not already held.

void AcquireLocatedEventRevealedLock();