Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2223793002: X87: [x64][ia32] Add Support for the Float64Neg and Float32Neg turbofan operators. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [x64][ia32] Add Support for the Float64Neg and Float32Neg turbofan operators. port f68059b73aefd0b03ac3b04f8781d42ea4288237 (r38383) original commit message: Benedikt, do you think we could also provide these operators on mips, maybe by expanding them to "-0.0 -x"? If mips can provide these operators, then we could make Float64Neg and Float32Neg real operators and not just OptionalOperators. BUG= Committed: https://crrev.com/59e2d106bab70a1cb68fc126433bf88f5b91429d Cr-Commit-Position: refs/heads/master@{#38464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-08 09:35:39 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-09 02:36:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223793002/1
4 years, 4 months ago (2016-08-09 02:55:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 06:44:41 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 06:45:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59e2d106bab70a1cb68fc126433bf88f5b91429d
Cr-Commit-Position: refs/heads/master@{#38464}

Powered by Google App Engine
This is Rietveld 408576698