Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome_elf/chrome_elf_main.cc

Issue 2223783003: [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser processes. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome_elf/chrome_elf_main.h" 5 #include "chrome_elf/chrome_elf_main.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <algorithm> 8 #include <algorithm>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
11 #include "base/strings/string16.h" 11 #include "base/strings/string16.h"
12 #include "base/win/iat_patch_function.h" 12 #include "base/win/iat_patch_function.h"
13 #include "build/build_config.h" 13 #include "build/build_config.h"
14 #include "chrome/app/chrome_crash_reporter_client_win.h" 14 #include "chrome/app/chrome_crash_reporter_client_win.h"
15 #include "chrome/install_static/install_util.h" 15 #include "chrome/install_static/install_util.h"
16 #include "chrome_elf/blacklist/blacklist.h" 16 #include "chrome_elf/blacklist/blacklist.h"
17 #include "chrome_elf/blacklist/crashpad_helper.h" 17 #include "chrome_elf/blacklist/crashpad_helper.h"
18 #include "chrome_elf/chrome_elf_constants.h" 18 #include "chrome_elf/chrome_elf_constants.h"
19 #include "chrome_elf/chrome_elf_security.h"
19 #include "components/crash/content/app/crashpad.h" 20 #include "components/crash/content/app/crashpad.h"
20 #include "components/crash/core/common/crash_keys.h" 21 #include "components/crash/core/common/crash_keys.h"
21 22
22 namespace { 23 namespace {
23 24
24 base::LazyInstance<std::vector<crash_reporter::Report>>::Leaky g_crash_reports = 25 base::LazyInstance<std::vector<crash_reporter::Report>>::Leaky g_crash_reports =
25 LAZY_INSTANCE_INITIALIZER; 26 LAZY_INSTANCE_INITIALIZER;
26 27
27 // Gets the exe name from the full path of the exe. 28 // Gets the exe name from the full path of the exe.
28 base::string16 GetExeName() { 29 base::string16 GetExeName() {
(...skipping 13 matching lines...) Expand all
42 return file_name_string; 43 return file_name_string;
43 } 44 }
44 45
45 void InitializeCrashReportingForProcess() { 46 void InitializeCrashReportingForProcess() {
46 // We want to initialize crash reporting only in chrome.exe 47 // We want to initialize crash reporting only in chrome.exe
47 if (GetExeName() != L"chrome.exe") 48 if (GetExeName() != L"chrome.exe")
48 return; 49 return;
49 ChromeCrashReporterClient::InitializeCrashReportingForProcess(); 50 ChromeCrashReporterClient::InitializeCrashReportingForProcess();
50 } 51 }
51 52
52 #if !defined(ADDRESS_SANITIZER)
53 // chrome_elf loads early in the process and initializes Crashpad. That in turn 53 // chrome_elf loads early in the process and initializes Crashpad. That in turn
54 // uses the SetUnhandledExceptionFilter API to set a top level exception 54 // uses the SetUnhandledExceptionFilter API to set a top level exception
55 // handler for the process. When the process eventually initializes, CRT sets 55 // handler for the process. When the process eventually initializes, CRT sets
56 // an exception handler which calls TerminateProcess which effectively bypasses 56 // an exception handler which calls TerminateProcess which effectively bypasses
57 // us. Ideally we want to be at the top of the unhandled exception filter 57 // us. Ideally we want to be at the top of the unhandled exception filter
58 // chain. However we don't have a good way of intercepting the 58 // chain. However we don't have a good way of intercepting the
59 // SetUnhandledExceptionFilter API in the sandbox. EAT patching kernel32 or 59 // SetUnhandledExceptionFilter API in the sandbox. EAT patching kernel32 or
60 // kernelbase should ideally work. However the kernel32 kernelbase dlls are 60 // kernelbase should ideally work. However the kernel32 kernelbase dlls are
61 // prebound which causes EAT patching to not work. Sidestep works. However it 61 // prebound which causes EAT patching to not work. Sidestep works. However it
62 // is only supported for 32 bit. For now we use IAT patching for the 62 // is only supported for 32 bit. For now we use IAT patching for the
(...skipping 10 matching lines...) Expand all
73 } 73 }
74 74
75 // Please refer above to more information about why we intercept the 75 // Please refer above to more information about why we intercept the
76 // SetUnhandledExceptionFilter API. 76 // SetUnhandledExceptionFilter API.
77 void DisableSetUnhandledExceptionFilter() { 77 void DisableSetUnhandledExceptionFilter() {
78 DWORD patched = g_set_unhandled_exception_filter.PatchFromModule( 78 DWORD patched = g_set_unhandled_exception_filter.PatchFromModule(
79 GetModuleHandle(nullptr), "kernel32.dll", "SetUnhandledExceptionFilter", 79 GetModuleHandle(nullptr), "kernel32.dll", "SetUnhandledExceptionFilter",
80 SetUnhandledExceptionFilterPatch); 80 SetUnhandledExceptionFilterPatch);
81 CHECK(patched == 0); 81 CHECK(patched == 0);
82 } 82 }
83 #endif // !defined(ADDRESS_SANITIZER)
84 83
85 } // namespace 84 } // namespace
86 85
87 void SignalChromeElf() { 86 void SignalChromeElf() {
88 blacklist::ResetBeacon(); 87 blacklist::ResetBeacon();
89 } 88 }
90 89
91 // This helper is invoked by code in chrome.dll to retrieve the crash reports. 90 // This helper is invoked by code in chrome.dll to retrieve the crash reports.
92 // See CrashUploadListCrashpad. Note that we do not pass an std::vector here, 91 // See CrashUploadListCrashpad. Note that we do not pass an std::vector here,
93 // because we do not want to allocate/free in different modules. The returned 92 // because we do not want to allocate/free in different modules. The returned
(...skipping 12 matching lines...) Expand all
106 const char* client_id) { 105 const char* client_id) {
107 if (client_id) 106 if (client_id)
108 crash_keys::SetMetricsClientIdFromGUID(client_id); 107 crash_keys::SetMetricsClientIdFromGUID(client_id);
109 } 108 }
110 109
111 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) { 110 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
112 if (reason == DLL_PROCESS_ATTACH) { 111 if (reason == DLL_PROCESS_ATTACH) {
113 InitializeCrashReportingForProcess(); 112 InitializeCrashReportingForProcess();
114 // CRT on initialization installs an exception filter which calls 113 // CRT on initialization installs an exception filter which calls
115 // TerminateProcess. We need to hook CRT's attempt to set an exception 114 // TerminateProcess. We need to hook CRT's attempt to set an exception
116 // handler and ignore it. Don't do this when ASan is present, or ASan will 115 // handler and ignore it.
117 // fail to install its own unhandled exception filter.
118 #if !defined(ADDRESS_SANITIZER)
119 DisableSetUnhandledExceptionFilter(); 116 DisableSetUnhandledExceptionFilter();
120 #endif
121 117
122 install_static::InitializeProcessType(); 118 install_static::InitializeProcessType();
119 if (install_static::g_process_type ==
120 install_static::ProcessType::BROWSER_PROCESS)
121 EarlyBrowserSecurity();
123 122
124 __try { 123 __try {
125 blacklist::Initialize(false); // Don't force, abort if beacon is present. 124 blacklist::Initialize(false); // Don't force, abort if beacon is present.
126 } __except(GenerateCrashDump(GetExceptionInformation())) { 125 } __except(GenerateCrashDump(GetExceptionInformation())) {
127 } 126 }
128 } 127 }
129 return TRUE; 128 return TRUE;
130 } 129 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698