components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java - Issue 2223773003: Expose effective connection type to Cronet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2223773003: Expose effective connection type to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes based on https://codereview.chromium.org/2210633002/ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java » ('j') | net/nqe/effective_connection_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

index b9eeef9e36fcd02b815b6a8dfac311a4b1ce6306..92204d2e771e434673d9b5e305ab0dae9afd9194 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

@@ -326,6 +326,11 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

assertEquals(mNetworkQualityThread, rttListener.getThread());

assertEquals(mNetworkQualityThread, throughputListener.getThread());

+ // Verify that effective connection type callback is received and

+ // effective connection type is correctly set.

+ assertTrue(mTestFramework.mCronetEngine.getEffectiveConnectionType()

+ != EffectiveConnectionType.EFFECTIVE_CONNECTION_TYPE_UNKNOWN);

mTestFramework.mCronetEngine.shutdown();

}