Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2223773003: Expose effective connection type to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased, addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/effective_connection_type.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.cc
diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc
index c31f9a4eda18754a2ad11b38cdc723e17df08b01..b32abe40dd56495063f85173e9a41a8c54e00c4f 100644
--- a/net/nqe/network_quality_estimator.cc
+++ b/net/nqe/network_quality_estimator.cc
@@ -1662,7 +1662,7 @@ void NetworkQualityEstimator::MaybeRecomputeEffectiveConnectionType() {
// last computed or a connection change event was observed since the last
// computation. Strict inequalities are used to ensure that effective
// connection type is recomputed on connection change events even if the clock
- // has not updated. Recompute the effective connection type if the effective
+ // has not updated. Recompute the effective connection type if the effective
// connection type was previously unavailable. This is because the RTT
// observations are voluminous, so it may now be possible to compute the
// effective connection type.
@@ -1684,6 +1684,7 @@ void NetworkQualityEstimator::MaybeRecomputeEffectiveConnectionType() {
void NetworkQualityEstimator::
NotifyObserversOfEffectiveConnectionTypeChanged() {
DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK_NE(EFFECTIVE_CONNECTION_TYPE_LAST, effective_connection_type_);
// TODO(tbansal): Add hysteresis in the notification.
FOR_EACH_OBSERVER(
« no previous file with comments | « net/nqe/effective_connection_type.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698