Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2223773002: Move zone_ to Scope (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move zone_ to Scope Pass in zone() explicitly to SloppyBlockFunctionMap::Declare and VariableMap::Declare instead. BUG=v8:5209 Committed: https://crrev.com/9ae45af5a40c5d6d9482ba620653edfeb1764ef1 Cr-Commit-Position: refs/heads/master@{#38424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -69 lines) Patch
M src/ast/scopes.h View 5 chunks +12 lines, -18 lines 0 comments Download
M src/ast/scopes.cc View 15 chunks +38 lines, -49 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-08 08:55:45 UTC) #2
marja
lgtm
4 years, 4 months ago (2016-08-08 09:04:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223773002/1
4 years, 4 months ago (2016-08-08 09:05:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 09:31:33 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 09:34:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ae45af5a40c5d6d9482ba620653edfeb1764ef1
Cr-Commit-Position: refs/heads/master@{#38424}

Powered by Google App Engine
This is Rietveld 408576698