Issue 2223743005: ios: fix iossim path

Issue 2223743005: ios: fix iossim path (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.

Modified:
4 years, 4 months ago

Reviewers:
Sergiy Byelozyorov, emso, smut, tandrii(chromium)

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

More Reviews

Description

ios: fix iossim path BUG=584079, 593999 Committed: https://chromium.googlesource.com/chromium/tools/build/+/9aa6e0a8124b331eb3c68900172ecbeb293deba3

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -35 lines)			Patch
M	scripts/slave/recipe_modules/ios/api.py	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	scripts/slave/recipe_modules/ios/example.expected/basic.json	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	scripts/slave/recipe_modules/ios/example.expected/clobber.json	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	scripts/slave/recipe_modules/ios/example.expected/test_failure.json	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/parent.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/ios/try.expected/swarming.json	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	scripts/slave/recipes/ios/try.expected/swarming_tests_skipped.json	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	scripts/slave/recipes/ios/unified_builder_tester.expected/infrastructure_failure.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/ios/unified_builder_tester.expected/multiple_failures.json	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	scripts/slave/recipes/ios/unified_builder_tester.expected/test_failure.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paweł Hajdan Jr.

Example failure: https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/3337/steps/base_unittests%20%28iPhone%205s%20iOS%209.0%29/logs/stdio : @@@STEP_TEXT@SimulatorNotFoundError: Simulator does not exist: /b/rr/tmpG_A3hT/w/src/out/Debug-iphonesimulator/iossim.@@@

4 years, 4 months ago (2016-08-09 12:03:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223743005/1

4 years, 4 months ago (2016-08-09 12:06:20 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/9aa6e0a8124b331eb3c68900172ecbeb293deba3

4 years, 4 months ago (2016-08-09 12:10:00 UTC) #7

smut

4 years, 4 months ago (2016-08-10 23:53:33 UTC) #9

Message was sent while issue was closed.

https://codereview.chromium.org/2223743005/diff/1/scripts/slave/recipes/ios/t...
File scripts/slave/recipes/ios/try.expected/swarming.json (right):

https://codereview.chromium.org/2223743005/diff/1/scripts/slave/recipes/ios/t...
scripts/slave/recipes/ios/try.expected/swarming.json:462:
"@@@STEP_LOG_LINE@template.isolate@           
\"[BUILDER_CACHE]/ios_simulator_swarming/src/out/Debug-iphonesimulator/iossim\",
@@@",
This is wrong. This command needs to use relative paths because the absolute
paths on the builder do not exist on Swarming.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages