chrome/android/java/res/layout/new_tab_page_action_card.xml - Issue 2223743004: 📰 Add an action button that can be used in sections

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_action_card.xml

Issue 2223743004: 📰 Add an action button that can be used in sections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- The Layout takes the regular NTP Card attributes (padding, background

	7 drawable) and adds the selectable ripple effects as foreground. The

	8 foreground property requires to use a FrameLayout. -->

	9 <FrameLayout

	10 xmlns:android="http://schemas.android.com/apk/res/android"

	11 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	12 android:layout_width="match_parent"

	13 android:layout_height="wrap_content"

	14 android:foreground="?attr/selectableItemBackgroundBorderless"

	15 android:clickable="true"

	16 android:padding="@dimen/snippets_padding_and_peeking_card_height"

	17 android:background="@drawable/ntp_card">

	18

	19 <!-- We don't use a button here since the effect and the click handler will

	20 be done at the parent level, directly on the layout. We transferred

	21 select styling properties from ButtonCompatBorderless and made it

	22 unfocusable.-->

	23 <TextView

	24 android:layout_width="wrap_content"

	25 android:layout_height="wrap_content"

	26 android:clickable="false"

	27 android:focusable="false"

	28 android:gravity="center_vertical\|center_horizontal"

	29 android:minHeight="36dp"

	30 android:paddingStart="8dp"

	31 android:text="@string/more"

	32 android:textAllCaps="true"

	33 android:textColor="@color/light_active_color"

	34 android:textSize="15sp"

	35 android:textStyle="bold" />

	36

	37 </FrameLayout>

OLD	NEW