MD User Manager: Changes to 'import supervised users' dialog.

MD User Manager: Changes to 'import supervised users' dialog.

1. Shows the 'no supervised users to import' message in the error banner instead.
2. Adds a shadow to the banner for better separation from the content area.
3. Changes paper-listbox's selected item style to Polymer's default.

BUG=635043, 635048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0
Cr-Commit-Position: refs/heads/master@{#410784}

[Moe, 2016-08-08 14:19:41]

Description was changed from

==========
MD User Manager: Changes to 'import supervised users' dialog.

1. Shows the 'no supervised users to import' message in the error banner
instead.
2. Adds a shadow to the banner for better separation from the content area.
3. Changes paper-listbox's selected item style to Polymer's default.

BUG=635043, 635048
==========

to

==========
MD User Manager: Changes to 'import supervised users' dialog.

1. Shows the 'no supervised users to import' message in the error banner
instead.
2. Adds a shadow to the banner for better separation from the content area.
3. Changes paper-listbox's selected item style to Polymer's default.

BUG=635043, 635048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-08-08 14:19:53]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 14:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-08-08 14:21:56]

mahmadi@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Moe, 2016-08-08 14:21:57]

Hi Michael, Please take a look at this.

[commit-bot: I haz the power, 2016-08-08 15:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 15:13:16]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-08-09 02:53:48]

lgtm

https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_u...
File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right):

https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/create_profile_tests.js:206:
assertFalse(createProfileElement.$$('#message-container').hidden);
nit: check foo.clientHeight > 0 instead of !foo.hidden

[Moe, 2016-08-09 14:02:26]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 14:02:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 15:16:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 15:16:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Moe, 2016-08-09 17:22:47]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 17:23:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-08-09 17:36:47]

Patchset #2 (id:20001) has been deleted

[Moe, 2016-08-09 18:15:42]

Thanks!

https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_u...
File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right):

https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/create_profile_tests.js:206:
assertFalse(createProfileElement.$$('#message-container').hidden);
On 2016/08/09 02:53:48, michaelpg wrote:
> nit: check foo.clientHeight > 0 instead of !foo.hidden

Done.

[commit-bot: I haz the power, 2016-08-09 19:49:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 19:49:39]

Dry run: This issue passed the CQ dry run.

[Moe, 2016-08-09 19:54:17]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-08-09 19:54:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2223743003/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-08-09 19:55:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:01:18]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-09 20:03:02]

Description was changed from

==========
MD User Manager: Changes to 'import supervised users' dialog.

1. Shows the 'no supervised users to import' message in the error banner
instead.
2. Adds a shadow to the banner for better separation from the content area.
3. Changes paper-listbox's selected item style to Polymer's default.

BUG=635043, 635048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD User Manager: Changes to 'import supervised users' dialog.

1. Shows the 'no supervised users to import' message in the error banner
instead.
2. Adds a shadow to the banner for better separation from the content area.
3. Changes paper-listbox's selected item style to Polymer's default.

BUG=635043, 635048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0
Cr-Commit-Position: refs/heads/master@{#410784}
==========

[commit-bot: I haz the power, 2016-08-09 20:03:03]

Patchset 2 (id:??) landed as
https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0
Cr-Commit-Position: refs/heads/master@{#410784}