Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2223743003: MD User Manager: Changes to 'import supervised users' dialog. (Closed)

Created:
4 years, 4 months ago by Moe
Modified:
4 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Changes to 'import supervised users' dialog. 1. Shows the 'no supervised users to import' message in the error banner instead. 2. Adds a shadow to the banner for better separation from the content area. 3. Changes paper-listbox's selected item style to Polymer's default. BUG=635043, 635048 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0 Cr-Commit-Position: refs/heads/master@{#410784}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -54 lines) Patch
M chrome/browser/resources/md_user_manager/create_profile.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.js View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_user_manager/import_supervised_user.html View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/resources/md_user_manager/import_supervised_user.js View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/data/webui/md_user_manager/create_profile_tests.js View 1 4 chunks +39 lines, -3 lines 0 comments Download
M chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Moe
Hi Michael, Please take a look at this.
4 years, 4 months ago (2016-08-08 14:21:57 UTC) #5
michaelpg
lgtm https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_user_manager/create_profile_tests.js File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right): https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_user_manager/create_profile_tests.js#newcode206 chrome/test/data/webui/md_user_manager/create_profile_tests.js:206: assertFalse(createProfileElement.$$('#message-container').hidden); nit: check foo.clientHeight > 0 instead of ...
4 years, 4 months ago (2016-08-09 02:53:48 UTC) #8
Moe
Thanks! https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_user_manager/create_profile_tests.js File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right): https://codereview.chromium.org/2223743003/diff/1/chrome/test/data/webui/md_user_manager/create_profile_tests.js#newcode206 chrome/test/data/webui/md_user_manager/create_profile_tests.js:206: assertFalse(createProfileElement.$$('#message-container').hidden); On 2016/08/09 02:53:48, michaelpg wrote: > nit: ...
4 years, 4 months ago (2016-08-09 18:15:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223743003/40001
4 years, 4 months ago (2016-08-09 19:55:08 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-09 20:01:18 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:03:03 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0
Cr-Commit-Position: refs/heads/master@{#410784}

Powered by Google App Engine
This is Rietveld 408576698