Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 222373002: Remove use of random_shuffle() in PermutedEntropyProvider. (Closed)

Created:
6 years, 8 months ago by Alexei Svitkine (slow)
Modified:
6 years, 8 months ago
Reviewers:
jwd
CC:
chromium-reviews
Visibility:
Public.

Description

Remove use of random_shuffle() in PermutedEntropyProvider. Although all current toolchains that we use have the same algorithm backing that function, it is apparently not guaranteed by the spec and the libc++ implementation differs. Since we rely on consistent results here, change the code to do its own shuffle using the same algorithm. Correctness is already covered by existing tests. BUG=358564 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M components/variations/entropy_provider.cc View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Alexei Svitkine (slow)
6 years, 8 months ago (2014-04-02 16:37:32 UTC) #1
jwd
lgtm
6 years, 8 months ago (2014-04-02 17:21:03 UTC) #2
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 8 months ago (2014-04-02 17:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/222373002/1
6 years, 8 months ago (2014-04-02 17:26:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 17:34:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-02 17:34:19 UTC) #6
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 8 months ago (2014-04-02 17:35:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/222373002/1
6 years, 8 months ago (2014-04-02 17:36:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 00:31:59 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60683
6 years, 8 months ago (2014-04-03 00:31:59 UTC) #10
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 8 months ago (2014-04-03 00:37:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/222373002/1
6 years, 8 months ago (2014-04-03 00:38:51 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:23 UTC) #13
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:24 UTC) #14
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 8 months ago (2014-04-03 13:51:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/222373002/1
6 years, 8 months ago (2014-04-03 13:51:36 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 14:41:44 UTC) #17
Message was sent while issue was closed.
Change committed as 261381

Powered by Google App Engine
This is Rietveld 408576698