net/third_party/nss/ssl/ssl.h - Issue 22237002: NSS: move the first protocol to the end of the ALPN extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/third_party/nss/ssl/ssl.h

Issue 22237002: NSS: move the first protocol to the end of the ALPN extension. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing wtc's comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/third_party/nss/ssl/ssl.h

diff --git a/net/third_party/nss/ssl/ssl.h b/net/third_party/nss/ssl/ssl.h

index 719425704c225bef1ffd582be589d92065396222..53810f7e12366e4d4d6bf416b0394ac3b95f387e 100644

--- a/net/third_party/nss/ssl/ssl.h

+++ b/net/third_party/nss/ssl/ssl.h

@@ -208,6 +208,10 @@ SSL_IMPORT SECStatus SSL_SetNextProtoCallback(PRFileDesc *fd,

* uses ALPN to select a protocol, SSL_GetNextProto will return

* SSL_NEXT_PROTO_SELECTED as the state.

+ * Since NPN uses the first protocol as the fallback protocol, when sending an

+ * ALPN extension, the first protocol is moved to the end of the list. This

+ * indicates that the protocol is the least preferred.

wtc 2013/08/06 18:08:56 Nit: the protocol => the fallback protocol ? We s

+ *

* The supported protocols are specified in |data| in wire-format (8-bit

* length-prefixed). For example: "\010http/1.1\006spdy/2". */

SSL_IMPORT SECStatus SSL_SetNextProtoNego(PRFileDesc *fd,

« no previous file with comments | « net/third_party/nss/patches/alpn.patch ('k') | net/third_party/nss/ssl/ssl3ext.c » ('j') | no next file with comments »