use onPeekBitmap instead of asLegacyBitmap

use onPeekBitmap instead of asLegacyBitmap

Since we know we are raster-backed at this point, it is fine, plus it avoids the copy-mutable logic in asLegacyBitmap, which is not needed here (and is slower if our bitmap was built with kNever_SkCopyPixelsMode).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223653002

Committed: https://skia.googlesource.com/skia/+/9a5a201472c3fb9f02b954ba09ae1ec13ebd50f4

[reed1, 2016-08-06 02:34:23]

Description was changed from

==========
use onPeekBitmap instead of asLegacyBitmap

Since we know we are raster-backed at this point, it is fine, plus it avoids the
copy-mutable logic in asLegacyBitmap, which is not needed here (and is slower if
our bitmap was built with kNever_SkCopyPixelsMode).

BUG=skia:
==========

to

==========
use onPeekBitmap instead of asLegacyBitmap

Since we know we are raster-backed at this point, it is fine, plus it avoids the
copy-mutable logic in asLegacyBitmap, which is not needed here (and is slower if
our bitmap was built with kNever_SkCopyPixelsMode).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223653002
==========

[reed1, 2016-08-06 02:35:03]

reed@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com, robertphillips@google.com

[reed1, 2016-08-06 02:35:11]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 02:35:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 02:51:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 02:51:43]

Dry run: This issue passed the CQ dry run.

[djsollen, 2016-08-06 03:21:22]

seems good to me, but as I don't touch this code often I'll defer to the gpu
guys.

[robertphillips, 2016-08-08 14:32:29]

https://codereview.chromium.org/2223653002/diff/1/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/2223653002/diff/1/src/image/SkImage_Gpu.cpp#n...
src/image/SkImage_Gpu.cpp:318: 
How do we know we're not in the SkImage_Generator case?

[reed1, 2016-08-08 15:19:30]

https://codereview.chromium.org/2223653002/diff/1/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/2223653002/diff/1/src/image/SkImage_Gpu.cpp#n...
src/image/SkImage_Gpu.cpp:318: 
On 2016/08/08 14:32:29, robertphillips wrote:
> How do we know we're not in the SkImage_Generator case?

Generator's have a cacherator (by definition), so they will be caught on line
314.

That said, I'll double check that we have a unittest for this API that covers
all of the image backing types [ texture, generator, raster ]

[reed1, 2016-08-08 15:36:59]

SkImage_newTextureImage seems to already exercise this. I think we're good to
go.

[bsalomon, 2016-08-08 15:37:20]

lgtm to the extent that I understand how raster images work.

[robertphillips, 2016-08-08 15:39:20]

lgtm

[reed1, 2016-08-08 15:39:47]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-08-08 15:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:00:31]

Description was changed from

==========
use onPeekBitmap instead of asLegacyBitmap

Since we know we are raster-backed at this point, it is fine, plus it avoids the
copy-mutable logic in asLegacyBitmap, which is not needed here (and is slower if
our bitmap was built with kNever_SkCopyPixelsMode).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223653002
==========

to

==========
use onPeekBitmap instead of asLegacyBitmap

Since we know we are raster-backed at this point, it is fine, plus it avoids the
copy-mutable logic in asLegacyBitmap, which is not needed here (and is slower if
our bitmap was built with kNever_SkCopyPixelsMode).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223653002

Committed:
https://skia.googlesource.com/skia/+/9a5a201472c3fb9f02b954ba09ae1ec13ebd50f4
==========

[commit-bot: I haz the power, 2016-08-08 16:00:32]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9a5a201472c3fb9f02b954ba09ae1ec13ebd50f4