Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2223623002: [worklets] Implement isJSExecutionIsForbidden call for WorkletGlobalScope. (Closed)

Created:
4 years, 4 months ago by ikilpatrick
Modified:
4 years, 4 months ago
Reviewers:
yhirano, nhiroki
CC:
chromium-reviews, blink-reviews, falken, kinuko+worker_chromium.org, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[worklets] Implement isJSExecutionIsForbidden call for WorkletGlobalScope. This method is currently unreachable for worklets (no events). Additionally moves isClosing method. BUG=567358 Committed: https://crrev.com/03e7cd75500ae29a36da17b854eea4f42c93186a Cr-Commit-Position: refs/heads/master@{#410343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletGlobalScope.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ikilpatrick
4 years, 4 months ago (2016-08-06 00:23:33 UTC) #4
nhiroki
lgtm
4 years, 4 months ago (2016-08-08 08:20:32 UTC) #7
yhirano
lgtm
4 years, 4 months ago (2016-08-08 09:09:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223623002/1
4 years, 4 months ago (2016-08-08 12:41:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 13:55:08 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 13:57:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03e7cd75500ae29a36da17b854eea4f42c93186a
Cr-Commit-Position: refs/heads/master@{#410343}

Powered by Google App Engine
This is Rietveld 408576698