Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: include/core/SkImageFilter.h

Issue 22236002: Remove warning comment from SkImageFilter. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkImageFilter.h
diff --git a/include/core/SkImageFilter.h b/include/core/SkImageFilter.h
index 78eb9aed2ad4ea4b40da001e1ac47a92d1244776..01b3e0bca85279231952913e927e057128be8b3a 100644
--- a/include/core/SkImageFilter.h
+++ b/include/core/SkImageFilter.h
@@ -21,25 +21,11 @@ class GrEffectRef;
class GrTexture;
/**
- * Experimental.
- *
* Base class for image filters. If one is installed in the paint, then
* all drawing occurs as usual, but it is as if the drawing happened into an
* offscreen (before the xfermode is applied). This offscreen bitmap will
* then be handed to the imagefilter, who in turn creates a new bitmap which
* is what will finally be drawn to the device (using the original xfermode).
- *
- * THIS SIGNATURE IS TEMPORARY
- *
- * There are several weaknesses in this function signature:
- * 1. Does not expose the destination/target device, so filters that can draw
- * directly to it are unable to take advantage of that optimization.
- * 2. Does not expose a way to create a "compabitible" image (i.e. gpu -> gpu)
- * 3. As with #1, the filter is unable to "read" the dest (which would be slow)
- *
- * Therefore, we should not create any real dependencies on this API yet -- it
- * is being checked in as a check-point so we can explore these and other
- * considerations.
*/
class SK_API SkImageFilter : public SkFlattenable {
public:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698