Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2223563002: headless: expose window size through headless_shell switch. (Closed)

Created:
4 years, 4 months ago by Eric Seckler
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose window size through a headless_shell switch. BUG=546953 Committed: https://crrev.com/2c13b37c42fdb8ac05b616e4ad4e0cf462949a0d Cr-Commit-Position: refs/heads/master@{#410140}

Patch Set 1 #

Total comments: 2

Patch Set 2 : allow 0x0 size. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M headless/app/headless_shell.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download
M headless/app/headless_shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M headless/app/headless_shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Eric Seckler
4 years, 4 months ago (2016-08-05 18:14:28 UTC) #3
Sami
https://codereview.chromium.org/2223563002/diff/1/headless/app/headless_shell.cc File headless/app/headless_shell.cc (right): https://codereview.chromium.org/2223563002/diff/1/headless/app/headless_shell.cc#newcode366 headless/app/headless_shell.cc:366: if (parsed_window_size.IsEmpty()) { 0x0 might be useful in some ...
4 years, 4 months ago (2016-08-05 18:18:25 UTC) #4
Eric Seckler
https://codereview.chromium.org/2223563002/diff/1/headless/app/headless_shell.cc File headless/app/headless_shell.cc (right): https://codereview.chromium.org/2223563002/diff/1/headless/app/headless_shell.cc#newcode366 headless/app/headless_shell.cc:366: if (parsed_window_size.IsEmpty()) { On 2016/08/05 18:18:25, Sami wrote: > ...
4 years, 4 months ago (2016-08-05 18:40:03 UTC) #5
Sami
lgtm, thanks!
4 years, 4 months ago (2016-08-05 18:45:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223563002/20001
4 years, 4 months ago (2016-08-05 18:48:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 19:23:35 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:25:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c13b37c42fdb8ac05b616e4ad4e0cf462949a0d
Cr-Commit-Position: refs/heads/master@{#410140}

Powered by Google App Engine
This is Rietveld 408576698