Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2223553003: Adds WmShell::RecordGestureAction() (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds WmShell::RecordGestureAction() mash isn't going to want all the constants defined in gesture_action_type, but the split can be done separately. I also didn't move TouchUMA directly as I believe most of that code needs to be moved to chrome and the renderer. BUG=634972 TEST=none R=msw@chromium.org Committed: https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0 Cr-Commit-Position: refs/heads/master@{#410149}

Patch Set 1 #

Patch Set 2 : fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -45 lines) Patch
M ash/ash.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A ash/common/metrics/gesture_action_type.h View 1 chunk +40 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/touch/touch_uma.h View 2 chunks +1 line, -28 lines 0 comments Download
M ash/touch/touch_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/touch_uma/touch_uma_ash.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
4 years, 4 months ago (2016-08-05 18:14:18 UTC) #1
msw
lgtm
4 years, 4 months ago (2016-08-05 18:32:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223553003/20001
4 years, 4 months ago (2016-08-05 19:12:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 19:53:45 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:55:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0
Cr-Commit-Position: refs/heads/master@{#410149}

Powered by Google App Engine
This is Rietveld 408576698