Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 222353003: add new test targets in chromium_builder_dbg_drmemory_win for DrMemory build (Closed)

Created:
6 years, 8 months ago by zhaoqin
Modified:
6 years, 8 months ago
Reviewers:
Derek Bruening
CC:
chromium-reviews
Visibility:
Public.

Description

add new test targets in chromium_builder_dbg_drmemory_win for DrMemory build - add content_browsertests, content_shell, and sync_unit_tests R=bruening@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261216

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/all.gyp View 2 chunks +3 lines, -0 lines 9 comments Download

Messages

Total messages: 10 (0 generated)
zhaoqin
6 years, 8 months ago (2014-04-02 16:28:48 UTC) #1
Derek Bruening
LGTM with notes for more tests we should add to the bot runlists https://codereview.chromium.org/222353003/diff/1/build/all.gyp File ...
6 years, 8 months ago (2014-04-02 16:35:38 UTC) #2
zhaoqin
https://codereview.chromium.org/222353003/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/222353003/diff/1/build/all.gyp#newcode1058 build/all.gyp:1058: '../cloud_print/cloud_print.gyp:cloud_print_unittests', On 2014/04/02 16:35:38, Derek Bruening wrote: > Hmm, ...
6 years, 8 months ago (2014-04-02 16:40:17 UTC) #3
zhaoqin
The CQ bit was checked by zhaoqin@google.com
6 years, 8 months ago (2014-04-02 16:40:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@google.com/222353003/1
6 years, 8 months ago (2014-04-02 16:40:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 23:02:51 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60605
6 years, 8 months ago (2014-04-02 23:02:51 UTC) #7
zhaoqin
The CQ bit was checked by zhaoqin@google.com
6 years, 8 months ago (2014-04-02 23:22:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@google.com/222353003/1
6 years, 8 months ago (2014-04-02 23:24:15 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 23:28:36 UTC) #10
Message was sent while issue was closed.
Change committed as 261216

Powered by Google App Engine
This is Rietveld 408576698