Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: src/ast/ast-value-factory.h

Issue 2223523002: [Interpreter] Avoid dereferencing handles on BytecodeGenerator for AST operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_const_array
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast/ast-value-factory.h
diff --git a/src/ast/ast-value-factory.h b/src/ast/ast-value-factory.h
index 9b17ba6514b498c7e0f3a78ced48727466302204..873da29a9165aa924f78beeba39c5d57f5d84fde 100644
--- a/src/ast/ast-value-factory.h
+++ b/src/ast/ast-value-factory.h
@@ -74,7 +74,9 @@ class AstRawString final : public AstString {
void Internalize(Isolate* isolate) override;
- bool AsArrayIndex(uint32_t* index) const;
+ bool AsArrayIndex(uint32_t* index,
+ HandleDereferenceMode deref_mode =
+ HandleDereferenceMode::kHandleDereferenceAllowed) const;
// The string is not null-terminated, use length() to find out the length.
const unsigned char* raw_data() const {
@@ -168,7 +170,9 @@ class AstValue : public ZoneObject {
return type_ == STRING && string_ == string;
}
- bool IsPropertyName() const;
+ bool IsPropertyName(
+ HandleDereferenceMode deref_mode =
+ HandleDereferenceMode::kHandleDereferenceAllowed) const;
bool BooleanValue() const;

Powered by Google App Engine
This is Rietveld 408576698