[Interpreter] Avoid dereferencing handles on BytecodeGenerator for AST operations.

src/ast/ast.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ast/ast.h"
 
 #include <cmath>  // For isfinite.
 
 #include "src/ast/prettyprinter.h"
 #include "src/ast/scopes.h"
@@ skipping 69 matching lines @@
 
 bool Expression::IsSmiLiteral() const {
   return IsLiteral() && AsLiteral()->value()->IsSmi();
 }
 
 
 bool Expression::IsStringLiteral() const {
   return IsLiteral() && AsLiteral()->value()->IsString();
 }
 
-bool Expression::IsPropertyName() const {
-  return IsLiteral() && AsLiteral()->IsPropertyName();
+bool Expression::IsPropertyName(HandleDereferenceMode deref_mode) const {
+  return IsLiteral() && AsLiteral()->IsPropertyName(deref_mode);
 }
 
 bool Expression::IsNullLiteral() const {
   if (!IsLiteral()) return false;
-  Handle<Object> value = AsLiteral()->value();
-  return !value->IsSmi() &&
-         value->IsNull(HeapObject::cast(*value)->GetIsolate());
+  return AsLiteral()->raw_value()->IsNull();
 }
 
 bool Expression::IsUndefinedLiteral() const {
   if (IsLiteral()) {
-    Handle<Object> value = AsLiteral()->value();
-    if (!value->IsSmi() &&
-        value->IsUndefined(HeapObject::cast(*value)->GetIsolate())) {
+    if (AsLiteral()->raw_value()->IsUndefined()) {
       return true;
     }
   }
 
   const VariableProxy* var_proxy = AsVariableProxy();
   if (var_proxy == NULL) return false;
   Variable* var = var_proxy->var();
   // The global identifier "undefined" is immutable. Everything
   // else could be reassigned.
   return var != NULL && var->IsUnallocatedOrGlobalSlot() &&
@@ skipping 751 matching lines @@
     return static_cast<const Node*>(this)->IsMonomorphic();
     PROPERTY_NODE_LIST(GENERATE_CASE)
     CALL_NODE_LIST(GENERATE_CASE)
 #undef GENERATE_CASE
     default:
       UNREACHABLE();
       return false;
   }
 }
 
-bool Call::IsUsingCallFeedbackICSlot(Isolate* isolate) const {
-  CallType call_type = GetCallType(isolate);
+bool Call::IsUsingCallFeedbackICSlot(
+    Isolate* isolate, HandleDereferenceMode dereference_mode) const {
+  CallType call_type = GetCallType(isolate, dereference_mode);
   if (call_type == POSSIBLY_EVAL_CALL) {
     return false;
   }
   return true;
 }
 
-
-bool Call::IsUsingCallFeedbackSlot(Isolate* isolate) const {
+bool Call::IsUsingCallFeedbackSlot(
+    Isolate* isolate, HandleDereferenceMode dereference_mode) const {
   // SuperConstructorCall uses a CallConstructStub, which wants
   // a Slot, in addition to any IC slots requested elsewhere.
-  return GetCallType(isolate) == SUPER_CALL;
+  return GetCallType(isolate, dereference_mode) == SUPER_CALL;
 }
 
 
 void Call::AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec,
                                      FeedbackVectorSlotCache* cache) {
   if (IsUsingCallFeedbackICSlot(isolate)) {
     ic_slot_ = spec->AddCallICSlot();
   }
   if (IsUsingCallFeedbackSlot(isolate)) {
     stub_slot_ = spec->AddGeneralSlot();
   }
 }
 
-
-Call::CallType Call::GetCallType(Isolate* isolate) const {
+Call::CallType Call::GetCallType(Isolate* isolate,
+                                 HandleDereferenceMode deref_mode) const {
   VariableProxy* proxy = expression()->AsVariableProxy();
   if (proxy != NULL) {
-    if (proxy->var()->is_possibly_eval(isolate)) {
+    if (proxy->var()->is_possibly_eval(isolate, deref_mode)) {
       return POSSIBLY_EVAL_CALL;
     } else if (proxy->var()->IsUnallocatedOrGlobalSlot()) {
       return GLOBAL_CALL;
     } else if (proxy->var()->IsLookupSlot()) {
       return LOOKUP_SLOT_CALL;
     }
   }
 
   if (expression()->IsSuperCallReference()) return SUPER_CALL;
 
   Property* property = expression()->AsProperty();
   if (property != nullptr) {
     bool is_super = property->IsSuperAccess();
-    if (property->key()->IsPropertyName()) {
+    if (property->key()->IsPropertyName(deref_mode)) {
       return is_super ? NAMED_SUPER_PROPERTY_CALL : NAMED_PROPERTY_CALL;
     } else {
       return is_super ? KEYED_SUPER_PROPERTY_CALL : KEYED_PROPERTY_CALL;
     }
   }
 
   return OTHER_CALL;
 }
 
 
@@ skipping 12 matching lines @@
 
 
 // static
 bool Literal::Match(void* literal1, void* literal2) {
   const AstValue* x = static_cast<Literal*>(literal1)->raw_value();
   const AstValue* y = static_cast<Literal*>(literal2)->raw_value();
   return (x->IsString() && y->IsString() && x->AsString() == y->AsString()) ||
          (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber());
 }
 
-
 }  // namespace internal
 }  // namespace v8