chrome/browser/page_load_metrics/page_load_metrics_observer.cc - Issue 2223453003: Thread user gesture through page_load_metrics abort pipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2223453003: Thread user gesture through page_load_metrics abort pipeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: thread user gesture through page_load_metrics Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

index 56df7682f4ef972f5143b189ebd4f945f3afd899..4536dfdb3d5120391b9d36937c475d7da6838882 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

@@ -10,17 +10,21 @@ PageLoadExtraInfo::PageLoadExtraInfo(

const base::Optional<base::TimeDelta>& first_background_time,

const base::Optional<base::TimeDelta>& first_foreground_time,

bool started_in_foreground,

+ bool user_gesture,

const GURL& committed_url,

const base::Optional<base::TimeDelta>& time_to_commit,

UserAbortType abort_type,

+ bool abort_user_initiated,

const base::Optional<base::TimeDelta>& time_to_abort,

const PageLoadMetadata& metadata)

: first_background_time(first_background_time),

first_foreground_time(first_foreground_time),

started_in_foreground(started_in_foreground),

+ user_gesture(user_gesture),

committed_url(committed_url),

time_to_commit(time_to_commit),

abort_type(abort_type),

+ abort_user_initiated(abort_user_initiated),

time_to_abort(time_to_abort),

metadata(metadata) {}