Fix WebApkInstaller so that it can talk to the server

Fix WebApkInstaller so that it can talk to the server

This CL:
- Fixes webapk.proto to match what the server uses
- Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to
  the server in WebApkInstaller::SendCreateWebApkRequest()
- Increases the timeout to get a response from the WebAPK server. Currently the
  WebAPK server takes > 10 seconds to respond

BUG=619739
TEST=Manual

Committed: https://crrev.com/780b514674d00c784a3fd690910c79cbe697b015
Cr-Commit-Position: refs/heads/master@{#410287}

[pkotwicz, 2016-08-05 12:57:36]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-08-05 13:02:56]

Description was changed from

==========
Fix WebApkInstaller so that it can talk to the server

This CL:
- Fixes webapk.proto to match what the server uses
- Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to
  the server in WebApkInstaller::SendCreateWebApkRequest()

BUG=619739
TEST=Manual
==========

to

==========
Fix WebApkInstaller so that it can talk to the server

This CL:
- Fixes webapk.proto to match what the server uses
- Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to
  the server in WebApkInstaller::SendCreateWebApkRequest()
- Increases the timeout to get a response from the WebAPK server. Currently the
  WebAPK server takes > 10 seconds to respond

BUG=619739
TEST=Manual
==========

[pkotwicz, 2016-08-05 13:02:56]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-08-05 13:36:37]

pkotwicz@chromium.org changed reviewers:
+ hartmanng@chromium.org

[pkotwicz, 2016-08-05 13:36:37]

Xi and Glenn can you please take a look?

[hartmanng, 2016-08-05 13:52:17]

lgtm

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk.proto (right):

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
chrome/browser/android/webapk/webapk.proto:20: reserved 2, 4;
I'm curious about these reserved fields - are these just fields that exist on
the server-side proto but the client doesn't need to use yet? Is there a benefit
of listing them as reserved instead of just copying the server-side names and
types, or is it just for brevity?

[pkotwicz, 2016-08-05 14:25:30]

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk.proto (right):

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
chrome/browser/android/webapk/webapk.proto:20: reserved 2, 4;
Yes, these are fields that exist in the server side proto but that the client
does not need. My (unrealistic) hope is that some of these fields can be removed
from the server side proto prior to launch

[Xi Han, 2016-08-05 15:56:52]

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk.proto (right):

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
chrome/browser/android/webapk/webapk.proto:23: // Sent as part of request to
create a WebAPK.
Are you sure we can remove the class CreateWebApkRequest entirely? I though it
would be used as the type of the request, otherwise, how does the server know if
it is a CreateWebApkRequest or UpdateWebApkRequest?

[hartmanng, 2016-08-05 16:01:02]

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk.proto (right):

https://codereview.chromium.org/2223443002/diff/20001/chrome/browser/android/...
chrome/browser/android/webapk/webapk.proto:23: // Sent as part of request to
create a WebAPK.
On 2016/08/05 15:56:52, Xi Han wrote:
> Are you sure we can remove the class CreateWebApkRequest entirely? I though it
> would be used as the type of the request, otherwise, how does the server know
if
> it is a CreateWebApkRequest or UpdateWebApkRequest?

I believe the request URL is different for Update requests.

[Xi Han, 2016-08-05 17:22:13]

lgtm

[Xi Han, 2016-08-05 18:28:32]

If this CL depends on CL (https://codereview.chromium.org/2138973002/), you need
to update the webapk_installer_unittest.cc too.

[pkotwicz, 2016-08-07 03:40:54]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-08-07 03:40:55]

dfalcantara@ for OWNERS

[gone, 2016-08-07 15:47:44]

LGTM % question

https://codereview.chromium.org/2223443002/diff/40001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer.cc (right):

https://codereview.chromium.org/2223443002/diff/40001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer.cc:45: // the WebAPK server.
60 seconds is really long for just getting a download URL isn't it?  What will
users be seeing during this time?

[pkotwicz, 2016-08-07 21:00:42]

https://codereview.chromium.org/2223443002/diff/40001/chrome/browser/android/...
File chrome/browser/android/webapk/webapk_installer.cc (right):

https://codereview.chromium.org/2223443002/diff/40001/chrome/browser/android/...
chrome/browser/android/webapk/webapk_installer.cc:45: // the WebAPK server.
In practice the server takes 10 - 20 seconds. It feels like a really long time. 
I really hope that it can be improved.

The time should be a lot faster if the URL is requested for a WebAPK that the
WebAPK server knows about. (The WebAPK server crawls the internet and generates
WebAPKs for WebAPKeable sites that it finds)

While they are waiting, users will see an infobar informing them that a WebAPK
is being generated.

[pkotwicz, 2016-08-07 21:00:49]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-08-07 21:00:52]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org,
hartmanng@chromium.org
Link to the patchset: https://codereview.chromium.org/2223443002/#ps40001
(title: "Merge branch 'master' into webapk_builder_impl3")

[commit-bot: I haz the power, 2016-08-07 21:01:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-07 21:31:16]

Description was changed from

==========
Fix WebApkInstaller so that it can talk to the server

This CL:
- Fixes webapk.proto to match what the server uses
- Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to
  the server in WebApkInstaller::SendCreateWebApkRequest()
- Increases the timeout to get a response from the WebAPK server. Currently the
  WebAPK server takes > 10 seconds to respond

BUG=619739
TEST=Manual
==========

to

==========
Fix WebApkInstaller so that it can talk to the server

This CL:
- Fixes webapk.proto to match what the server uses
- Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to
  the server in WebApkInstaller::SendCreateWebApkRequest()
- Increases the timeout to get a response from the WebAPK server. Currently the
  WebAPK server takes > 10 seconds to respond

BUG=619739
TEST=Manual
==========

[commit-bot: I haz the power, 2016-08-07 21:31:17]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-07 21:33:09]

Description was changed from

==========
Fix WebApkInstaller so that it can talk to the server

This CL:
- Fixes webapk.proto to match what the server uses
- Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to
  the server in WebApkInstaller::SendCreateWebApkRequest()
- Increases the timeout to get a response from the WebAPK server. Currently the
  WebAPK server takes > 10 seconds to respond

BUG=619739
TEST=Manual
==========

to

==========
Fix WebApkInstaller so that it can talk to the server

This CL:
- Fixes webapk.proto to match what the server uses
- Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to
  the server in WebApkInstaller::SendCreateWebApkRequest()
- Increases the timeout to get a response from the WebAPK server. Currently the
  WebAPK server takes > 10 seconds to respond

BUG=619739
TEST=Manual

Committed: https://crrev.com/780b514674d00c784a3fd690910c79cbe697b015
Cr-Commit-Position: refs/heads/master@{#410287}
==========

[commit-bot: I haz the power, 2016-08-07 21:33:10]

Patchset 2 (id:??) landed as
https://crrev.com/780b514674d00c784a3fd690910c79cbe697b015
Cr-Commit-Position: refs/heads/master@{#410287}