Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2223433003: Revert of Add joinable option to SimpleThread::Options as was just done for Thread. (Closed)

Created:
4 years, 4 months ago by justincohen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, kinuko+watch, jam, darin-cc_chromium.org, blink-worker-reviews_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@b1_nonjoinable_thread
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add joinable option to SimpleThread::Options as was just done for Thread. (patchset #2 id:20001 of https://codereview.chromium.org/2204333003/ ) Reason for revert: Reverting this since it is breaking the iOS base_unittests. gba@ is working on a fix in https://codereview.chromium.org/2218983003/ Original issue's description: > Add joinable option to SimpleThread::Options as was just done for Thread::Options. > > SimpleThread will be more suitable than Thread for > https://codereview.chromium.org/2197753002/ per it not needing a MessageLoop. > > Also, cleanup the SimpleThread::Options API, making it more like Thread::Options. > > BUG=629716 > TBR=avi@chromium.org > > Committed: https://crrev.com/8b35b0572443f4a84377a1fbd199a1edabe3d7d6 > Cr-Commit-Position: refs/heads/master@{#409830} TBR=thestig@chromium.org,avi@chromium.org,gab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -69 lines) Patch
M base/threading/simple_thread.h View 6 chunks +18 lines, -25 lines 0 comments Download
M base/threading/simple_thread.cc View 2 chunks +19 lines, -11 lines 0 comments Download
M base/threading/simple_thread_unittest.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M content/renderer/categorized_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
justincohen
Created Revert of Add joinable option to SimpleThread::Options as was just done for Thread.
4 years, 4 months ago (2016-08-05 20:03:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223433003/1
4 years, 4 months ago (2016-08-05 20:03:48 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/246420) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-05 20:06:05 UTC) #5
justincohen
4 years, 4 months ago (2016-08-05 20:32:01 UTC) #6
Rebased here since I couldn't update this:
 https://codereview.chromium.org/2219663006/edit

Powered by Google App Engine
This is Rietveld 408576698