Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2223423003: Revert of [heap] Enable black allocation when finalizing incremental marking. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Enable black allocation when finalizing incremental marking. (patchset #1 id:1 of https://codereview.chromium.org/2224153003/ ) Reason for revert: crashing on ToT Original issue's description: > [heap] Enable black allocation when finalizing incremental marking. > > BUG=chromium:630386 > > Committed: https://crrev.com/bb4e028648a27a6958afc9b5040366b899cda50d > Cr-Commit-Position: refs/heads/master@{#38487} TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630386 Committed: https://crrev.com/d45f84523768d8e2075e45c830a2304d88c4d957 Cr-Commit-Position: refs/heads/master@{#38490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Enable black allocation when finalizing incremental marking.
4 years, 4 months ago (2016-08-09 12:58:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223423003/1
4 years, 4 months ago (2016-08-09 12:58:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 12:58:31 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 12:58:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d45f84523768d8e2075e45c830a2304d88c4d957
Cr-Commit-Position: refs/heads/master@{#38490}

Powered by Google App Engine
This is Rietveld 408576698