Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2223403002: Fix position of breadcrumbs list to consider RTL (Closed)

Created:
4 years, 4 months ago by harukam
Modified:
4 years, 4 months ago
Reviewers:
fukino, harukam1
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix position of breadcrumbs list to consider RTL BUG=634227 TEST=manually tested Committed: https://crrev.com/ae57951136729b82dc0f4184bcf24752e3efe092 Cr-Commit-Position: refs/heads/master@{#411015}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix position of breadcrumbs list to consider RTL #

Patch Set 3 : Fix position of breadcrumbs list to consider RTL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
harukam1
PTAL
4 years, 4 months ago (2016-08-09 06:37:45 UTC) #3
fukino
https://codereview.chromium.org/2223403002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/2223403002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1098 ui/file_manager/file_manager/foreground/css/file_manager.css:1098: margin-left: 0; Use 2 spaces as indents. We refer ...
4 years, 4 months ago (2016-08-09 06:52:19 UTC) #4
harukam1
PTAL https://codereview.chromium.org/2223403002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/2223403002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1098 ui/file_manager/file_manager/foreground/css/file_manager.css:1098: margin-left: 0; On 2016/08/09 06:52:18, fukino wrote: > ...
4 years, 4 months ago (2016-08-09 09:30:38 UTC) #5
harukam1
PTAL
4 years, 4 months ago (2016-08-10 07:38:04 UTC) #6
fukino
LGTM. Thanks!
4 years, 4 months ago (2016-08-10 07:48:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223403002/40001
4 years, 4 months ago (2016-08-10 09:03:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 09:48:24 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 09:49:45 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae57951136729b82dc0f4184bcf24752e3efe092
Cr-Commit-Position: refs/heads/master@{#411015}

Powered by Google App Engine
This is Rietveld 408576698