Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analyzer/lib/src/task/strong/checker.dart

Issue 2223343002: fix #26896, mark all @proxy ops as dynamic (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: make null safe Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/mock_sdk.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/strong/checker.dart
diff --git a/pkg/analyzer/lib/src/task/strong/checker.dart b/pkg/analyzer/lib/src/task/strong/checker.dart
index 19e1c8c02bbc57e12372d140195c568a86a416b5..85957f6bd9c5e98c73928f43fe4f6d41e67faadf 100644
--- a/pkg/analyzer/lib/src/task/strong/checker.dart
+++ b/pkg/analyzer/lib/src/task/strong/checker.dart
@@ -1029,7 +1029,10 @@ class CodeChecker extends RecursiveAstVisitor {
// Null type happens when we have unknown identifiers, like a dart: import
// that doesn't resolve.
var type = node.staticType;
- return type == null || type.isDynamic;
+ var element = type?.element;
+ return type == null ||
+ type.isDynamic ||
+ (element is ClassElement && element.isOrInheritsProxy);
vsm 2016/08/09 15:20:51 Is this too conservative if there is an actual met
Jennifer Messerly 2016/08/09 15:31:11 This path actually only handles operators. Method/
}
bool _isLibraryPrefix(Expression node) =>
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/mock_sdk.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698