third_party/libopenjpeg20/0021-tcd_init_tile_negative.patch - Issue 2223303002: openjpeg: Prevent negative x, y values in opj_tcd_init_tile

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libopenjpeg20/0021-tcd_init_tile_negative.patch

Issue 2223303002: openjpeg: Prevent negative x, y values in opj_tcd_init_tile (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 diff --git a/third_party/libopenjpeg20/tcd.c b/third_party/libopenjpeg20/tcd.c

	2 index 9270efe..06eee4e 100644

	3 --- a/third_party/libopenjpeg20/tcd.c

	4 +++ b/third_party/libopenjpeg20/tcd.c

	5 @@ -706,9 +706,16 @@ static INLINE OPJ_BOOL opj_tcd_init_tile(opj_tcd_t *p_tcd, OPJ_UINT32 p_tile_no,

	6 l_tx0 = l_cp->tx0 + p * l_cp->tdx; /* can't be greater than l_image->x1 so won't overflow */

	7 l_tile->x0 = (OPJ_INT32)opj_uint_max(l_tx0, l_image->x0);

	8 l_tile->x1 = (OPJ_INT32)opj_uint_min(opj_uint_adds(l_tx0, l_cp->tdx), l_ image->x1);

	9 + if (l_tile->x0 < 0 \|\| l_tile->x1 < 0) {

	10 + return OPJ_FALSE;

	11 + }

	12 +

	13 l_ty0 = l_cp->ty0 + q * l_cp->tdy; /* can't be greater than l_image->y1 so won't overflow */

	14 l_tile->y0 = (OPJ_INT32)opj_uint_max(l_ty0, l_image->y0);

	15 l_tile->y1 = (OPJ_INT32)opj_uint_min(opj_uint_adds(l_ty0, l_cp->tdy), l_ image->y1);

	16 + if (l_tile->y0 < 0 \|\| l_tile->y1 < 0) {

	17 + return OPJ_FALSE;

	18 + }

	19

	20 /* testcase 1888.pdf.asan.35.988 */

	21 if (l_tccp->numresolutions == 0) {

OLD	NEW

« no previous file with comments | « no previous file | third_party/libopenjpeg20/README.pdfium » ('j') | no next file with comments »