Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2223293004: find_unmapped_histograms.py: Skip unknown histogram names (Closed)

Created:
4 years, 4 months ago by Adam Rice
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@find_unmapped_histograms_filetypes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

find_unmapped_histograms.py: Skip unknown histogram names Previously, tools/metrics/find_unmapped_histograms.py would attempt to process all macros which contained the string UMA_HISTOGRAM. Some of these had different semantics and so produced false positives. Instead, add a whitelist of macros that the script knows how to process. Warnings are issued about other macros which are encountered. Diff between before / after output: WARNING: base/android/animation_frame_time_histogram.cc contains non-literal histogram name <histogram_name.c_str(> +WARNING: chromecast/base/metrics/cast_histograms.h:25: Unknown macro name: <UMA_HISTOGRAM_CUSTOM_TIMES_NO_CACHE> +WARNING: chromecast/base/metrics/cast_histograms.h:31: Unknown macro name: <UMA_HISTOGRAM_CUSTOM_COUNTS_NO_CACHE> +WARNING: chromecast/base/metrics/cast_histograms.h:37: Unknown macro name: <UMA_HISTOGRAM_ENUMERATION_NO_CACHE> WARNING: content/renderer/pepper/content_decryptor_delegate.cc contains non-literal histogram name <"Media.EME." + media::GetKeySystemNameForUMA(key_system> @@ -14,2 +17,3 @@ WARNING: chrome/browser/prerender/prerender_histograms.cc contains non-literal histogram name <base::StringPrintf("Prerender.OmniboxNavigationsUsedPrerenderCount%s"> +WARNING: cc/trees/layer_tree_host_impl.cc:164: Unknown macro name: <DEFINE_SCOPED_UMA_HISTOGRAM_TIMER> WARNING: cc/trees/layer_tree_host_impl.cc contains non-literal histogram name <base::StringPrintf("Compositing.%s.PictureMemoryUsageKb"> @@ -19,12 +23,20 @@ WARNING: chrome/browser/download/download_danger_prompt.cc contains non-literal histogram name <base::StringPrintf("%s.%s.Proceed"> +WARNING: components/startup_metric_utils/browser/startup_metric_utils.cc:128: Unknown macro name: <UMA_HISTOGRAM_WITH_TEMPERATURE> +WARNING: components/startup_metric_utils/browser/startup_metric_utils.cc:160: Unknown macro name: <UMA_HISTOGRAM_WITH_TEMPERATURE_AND_SAME_VERSION_COUNT> +WARNING: components/startup_metric_utils/browser/startup_metric_utils.cc:179: Unknown macro name: <UMA_HISTOGRAM_AND_TRACE_WITH_TEMPERATURE> +WARNING: components/startup_metric_utils/browser/startup_metric_utils.cc:191: Unknown macro name: <UMA_HISTOGRAM_AND_TRACE_WITH_TEMPERATURE_AND_SAME_VERSION_COUNT> +WARNING: base/metrics/histogram_macros.h:275: Unknown macro name: <SCOPED_UMA_HISTOGRAM_TIMER_EXPANDER> +WARNING: base/metrics/histogram_macros.h:285: Unknown macro name: <SCOPED_UMA_HISTOGRAM_TIMER_UNIQUE> WARNING: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc contains non-literal histogram name <uma> WARNING: cc/raster/one_copy_raster_buffer_provider.cc contains non-literal histogram name <base::StringPrintf("Renderer4.%s.PartialRasterPercentageSaved.OneCopy"> +WARNING: cc/scheduler/compositor_timing_history.cc:108: Unknown macro name: <UMA_HISTOGRAM_CUSTOM_TIMES_VSYNC_ALIGNED> +WARNING: cc/scheduler/compositor_timing_history.cc:117: Unknown macro name: <UMA_HISTOGRAM_CUSTOM_TIMES_DURATION> WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram name <time.c_str(> WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram name <time_per.c_str(> +WARNING: content/child/web_database_observer_impl.cc:48: Unknown macro name: <UMA_HISTOGRAM_WEBSQL_RESULT> +WARNING: cc/tiles/tile_manager.cc:40: Unknown macro name: <DEFINE_SCOPED_UMA_HISTOGRAM_AREA_TIMER> WARNING: cc/raster/gpu_raster_buffer_provider.cc contains non-literal histogram name <base::StringPrintf("Renderer4.%s.PartialRasterPercentageSaved.Gpu"> -WARNING: chromecast/browser/metrics/external_metrics.cc contains non-literal histogram name <sample.name(> -WARNING: chromecast/browser/metrics/external_metrics.cc contains non-literal histogram name <sample.name(> +WARNING: chrome/browser/net/request_source_bandwidth_histograms.cc:41: Unknown macro name: <UMA_HISTOGRAM_RESPONSE_KB> WARNING: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc contains non-literal histogram name <params->metric_name> WARNING: chrome/browser/predictors/autocomplete_action_predictor.cc contains non-literal histogram name <base::StringPrintf("Prerender.OmniboxNavigationsCouldPrerender%s"> -WARNING: cc/base/histograms.h contains non-literal histogram name <// ScopedReticulateSplinesTimer> WARNING: cc/base/histograms.h contains non-literal histogram name <base::StringPrintf(time_histogram> @@ -57,6 +69,4 @@ INFO: Autofill.KeyboardAccessoryButtonsIOS_ScreenReaderOn - 0x08f97fb1a13af290 -INFO: BeginResult - 0x6f42084be75ea43b INFO: Bookmarks.CreateBookmarkIndexTime - 0x22dbb7a64293f927 INFO: Bookmarks.DecodeTime - 0x807c2068685e48bb -INFO: Browser - 0xef15fd2f45e6bb5c INFO: Cache.ActiveCapacityMB - 0x9a62dfb292eb2144 @@ -75,3 +85,2 @@ INFO: Cellular.SIMLocked - 0x7fb31c2b69aa80fb -INFO: ChangeVersionResult - 0xfa5be9d5d447cd80 INFO: ChildProcessSecurityPolicy.FilePermissionPathLength - 0x92c6db4cf6e580c5 @@ -87,3 +96,2 @@ INFO: CloudPrint.XmppTimeout - 0xb948540eef7eacfa -INFO: CommitResult - 0xc0eecbfb87118d7a INFO: ConflictingModule.UserSelection - 0x8f6918337f598cd5 @@ -228,3 +236,2 @@ INFO: Omnibox.SearchProvider.GetMostRecentKeywordTermsDefaultProviderTime - 0x75e7670ee11aee48 -INFO: OpenResult - 0x8d097f7509702085 INFO: Overscroll.ScreenshotSize - 0xed29f0168cc9005e @@ -250,3 +257,2 @@ INFO: RemovableDeviceNotificationsLinux.device_partition_size_available - 0xb8a150e488fefab1 -INFO: Renderer - 0x07b20ae970048fc2 INFO: ResourceBundle.LoadLocaleResourcesError - 0x88915b4c5ad3bda3 @@ -280,3 +286,2 @@ INFO: SpellCheck.api.showUI - 0xd0c30938b7a87497 -INFO: StatementResult - 0x345b32983c99be05 INFO: Storage.BlobItemSize.CacheEntry - 0xf20160aaa3d807b5 @@ -297,3 +302,2 @@ INFO: Touchpad.ThreeFingerClick.Started - 0x708f17ee567d8f4e -INFO: Unknown - 0x88183b946cc5f0e8 INFO: VirtualKeyboard.FirstLoadTime - 0xf2437a04b25a860e R=isherman@chromium.org BUG=635449 Committed: https://crrev.com/c65a4b5cb7790a84ed716d5c7ad01a1906e34c97 Cr-Commit-Position: refs/heads/master@{#411955}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -5 lines) Patch
M tools/metrics/histograms/find_unmapped_histograms.py View 1 3 chunks +42 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Adam Rice
4 years, 4 months ago (2016-08-09 08:11:18 UTC) #1
Ilya Sherman
LGTM, thanks!
4 years, 4 months ago (2016-08-10 06:28:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223293004/20001
4 years, 4 months ago (2016-08-15 11:21:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 11:49:09 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 11:51:09 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c65a4b5cb7790a84ed716d5c7ad01a1906e34c97
Cr-Commit-Position: refs/heads/master@{#411955}

Powered by Google App Engine
This is Rietveld 408576698