Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2223293002: Replace 4096 with rendering quantum size (Closed)

Created:
4 years, 4 months ago by Raymond Toy
Modified:
4 years, 4 months ago
Reviewers:
hongchan
CC:
Raymond Toy, blink-reviews, chromium-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace 4096 with rendering quantum size The code for AudioBufferSourceHandler::renderFromBuffer had a magic, undocumented literal value of 4096. Replace this with AudioUtilities::kRenderQuantumFrames, because it's clear that the |numberOfFrames| can't be larger than the quantum size (from the call tree). The destination bus should also have a maximum length of this size. BUG=631074 TEST=none Committed: https://crrev.com/d2fc3f0348fa4b75175bb1892895dbbe621df417 Cr-Commit-Position: refs/heads/master@{#411437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Raymond Toy
PTAL
4 years, 4 months ago (2016-08-08 22:25:37 UTC) #2
hongchan
lgtm
4 years, 4 months ago (2016-08-09 22:52:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223293002/1
4 years, 4 months ago (2016-08-10 16:30:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/270981)
4 years, 4 months ago (2016-08-10 20:06:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223293002/1
4 years, 4 months ago (2016-08-11 20:11:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 23:30:01 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:32:07 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2fc3f0348fa4b75175bb1892895dbbe621df417
Cr-Commit-Position: refs/heads/master@{#411437}

Powered by Google App Engine
This is Rietveld 408576698