Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2223283002: [Interpreter] Create ScopeInfos in ast-numbering phase. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@offheap_varchecks
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Create ScopeInfos in ast-numbering phase. Creates ScopeInfos during the ast-numbering phase so that they are already created during bytecode generation so that they don't need to be allocated during concurrent bytecode generation. BUG=v8:5203 Committed: https://crrev.com/27a60a38b1794a7c3bfdb8da334092bce943ebe6 Cr-Commit-Position: refs/heads/master@{#38542}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/ast/ast-numbering.cc View 2 chunks +14 lines, -0 lines 1 comment Download
M src/interpreter/bytecode-generator.cc View 3 chunks +2 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
rmcilroy
Michi, PTAL, thanks.
4 years, 4 months ago (2016-08-09 07:20:51 UTC) #6
Michael Starzinger
LGTM. https://codereview.chromium.org/2223283002/diff/1/src/ast/ast-numbering.cc File src/ast/ast-numbering.cc (right): https://codereview.chromium.org/2223283002/diff/1/src/ast/ast-numbering.cc#newcode237 src/ast/ast-numbering.cc:237: if (FLAG_ignition && node->scope() != nullptr && Just ...
4 years, 4 months ago (2016-08-09 07:38:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223283002/1
4 years, 4 months ago (2016-08-10 14:06:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 14:27:43 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:28:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27a60a38b1794a7c3bfdb8da334092bce943ebe6
Cr-Commit-Position: refs/heads/master@{#38542}

Powered by Google App Engine
This is Rietveld 408576698