Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2223263003: Fix horizontal and vertical padding for Cast icon in Ash system tray (Closed)

Created:
4 years, 4 months ago by tdanderson
Modified:
4 years, 4 months ago
Reviewers:
James Cook, Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix horizontal and vertical padding for Cast icon in Ash system tray The horizontal and vertical padding values for the Cast icon in the Ash system tray are incorrectly reversed. Use horizontal padding for a horizontal shelf and use vertical padding for a vertical shelf. BUG=635955 TEST=manual Committed: https://crrev.com/01746c493874c68d66969911d2a1bda71cb57002 Cr-Commit-Position: refs/heads/master@{#410718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/common/system/cast/tray_cast.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tdanderson
James, can you please take a look?
4 years, 4 months ago (2016-08-09 16:32:36 UTC) #4
Daniel Erat
lgtm haha, awesome bug. thanks!
4 years, 4 months ago (2016-08-09 16:39:02 UTC) #6
James Cook
LGTM. Given the simplicity of this fix, consider asking for a merge back to M53. ...
4 years, 4 months ago (2016-08-09 16:39:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223263003/1
4 years, 4 months ago (2016-08-09 16:43:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 17:13:20 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 17:15:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01746c493874c68d66969911d2a1bda71cb57002
Cr-Commit-Position: refs/heads/master@{#410718}

Powered by Google App Engine
This is Rietveld 408576698