Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 222323002: Move internal zip code from zip.cc to zip_internal.cc (Closed)

Created:
6 years, 8 months ago by João Eiras
Modified:
6 years, 7 months ago
Reviewers:
satorux1, hshi1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move internal zip code from zip.cc to zip_internal.cc Also added missing <vector> told by the linter, fixed leak of a zipFile in ZipWithFilterCallback in case of error, and corrected error in function name. BUG=359428 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267815

Patch Set 1 #

Total comments: 3

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -64 lines) Patch
M third_party/zlib/google/zip.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/zlib/google/zip.cc View 1 3 chunks +3 lines, -60 lines 0 comments Download
M third_party/zlib/google/zip_internal.h View 1 3 chunks +13 lines, -1 line 0 comments Download
M third_party/zlib/google/zip_internal.cc View 1 4 chunks +66 lines, -2 lines 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (0 generated)
João Eiras
Second part here (for reference, original review https://codereview.chromium.org/179963002/ )
6 years, 8 months ago (2014-04-02 15:22:49 UTC) #1
satorux1
Filed crbug.com/359428 and added BUG= line. BUG= line makes it easier to track changes.
6 years, 8 months ago (2014-04-03 05:06:37 UTC) #2
satorux1
https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip.cc File third_party/zlib/google/zip.cc (right): https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip.cc#newcode142 third_party/zlib/google/zip.cc:142: !path.value().empty() && success; one more space? https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip.cc#newcode149 third_party/zlib/google/zip.cc:149: success ...
6 years, 8 months ago (2014-04-03 05:10:53 UTC) #3
João Eiras
ping ?
6 years, 7 months ago (2014-04-29 14:48:35 UTC) #4
satorux1
On 2014/04/29 14:48:35, João Eiras wrote: > ping ? Didn't notice that the patch was ...
6 years, 7 months ago (2014-04-30 00:06:57 UTC) #5
satorux1
LGTM
6 years, 7 months ago (2014-04-30 00:10:54 UTC) #6
João Eiras
The CQ bit was checked by joaoe@opera.com
6 years, 7 months ago (2014-04-30 11:46:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001
6 years, 7 months ago (2014-04-30 11:46:19 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 11:49:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 11:49:10 UTC) #10
João Eiras
The CQ bit was checked by joaoe@opera.com
6 years, 7 months ago (2014-04-30 12:39:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001
6 years, 7 months ago (2014-04-30 12:39:40 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 13:32:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 13:32:09 UTC) #14
João Eiras
The CQ bit was checked by joaoe@opera.com
6 years, 7 months ago (2014-04-30 14:24:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001
6 years, 7 months ago (2014-04-30 14:24:49 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 14:48:14 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 14:48:14 UTC) #18
João Eiras
The CQ bit was checked by joaoe@opera.com
6 years, 7 months ago (2014-05-02 11:10:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001
6 years, 7 months ago (2014-05-02 11:11:24 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 11:46:26 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 11:46:26 UTC) #22
João Eiras
The CQ bit was checked by joaoe@opera.com
6 years, 7 months ago (2014-05-02 11:49:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001
6 years, 7 months ago (2014-05-02 11:50:06 UTC) #24
João Eiras
The CQ bit was checked by joaoe@opera.com
6 years, 7 months ago (2014-05-02 12:15:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001
6 years, 7 months ago (2014-05-02 12:15:40 UTC) #26
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 16:50:10 UTC) #27
Message was sent while issue was closed.
Change committed as 267815

Powered by Google App Engine
This is Rietveld 408576698