Move internal zip code from zip.cc to zip_internal.cc

Move internal zip code from zip.cc to zip_internal.cc

Also added missing <vector> told by the linter, fixed leak of a zipFile
in ZipWithFilterCallback in case of error, and corrected error in function name.

BUG=359428
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267815

[João Eiras, 2014-04-02 15:22:49]

Second part here

(for reference, original review  https://codereview.chromium.org/179963002/ )

[satorux1, 2014-04-03 05:06:37]

Filed crbug.com/359428 and added BUG= line. BUG= line makes it easier to track
changes.

[satorux1, 2014-04-03 05:10:53]

https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip.cc
File third_party/zlib/google/zip.cc (right):

https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip....
third_party/zlib/google/zip.cc:142: !path.value().empty() && success;
one more space?

https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip....
third_party/zlib/google/zip.cc:149: success = false;
add break here? then you don't need to check 'success' in the loop condition.

https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip_...
File third_party/zlib/google/zip_internal.h (right):

https://codereview.chromium.org/222323002/diff/1/third_party/zlib/google/zip_...
third_party/zlib/google/zip_internal.h:64: bool
ZipOpenNewFileInZipWrapper(zipFile zip_file,
Drop "Wrapper" from the function name?

[João Eiras, 2014-04-29 14:48:35]

ping ?

[satorux1, 2014-04-30 00:06:57]

On 2014/04/29 14:48:35, João Eiras wrote:
> ping ?

Didn't notice that the patch was updated. When you upload a new patch, please
do:

1) Reply each review comment. The easiest way is to click on "Done"
2) Then, send mail via "Publish+Mail Comments"

Then, reviewers are notified by email, with comments from you.

[satorux1, 2014-04-30 00:10:54]

LGTM

[João Eiras, 2014-04-30 11:46:00]

The CQ bit was checked by joaoe@opera.com

[commit-bot: I haz the power, 2014-04-30 11:46:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001

[commit-bot: I haz the power, 2014-04-30 11:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 11:49:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium

[João Eiras, 2014-04-30 12:39:31]

The CQ bit was checked by joaoe@opera.com

[commit-bot: I haz the power, 2014-04-30 12:39:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001

[commit-bot: I haz the power, 2014-04-30 13:32:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 13:32:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium

[João Eiras, 2014-04-30 14:24:20]

The CQ bit was checked by joaoe@opera.com

[commit-bot: I haz the power, 2014-04-30 14:24:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001

[commit-bot: I haz the power, 2014-04-30 14:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 14:48:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium

[João Eiras, 2014-05-02 11:10:59]

The CQ bit was checked by joaoe@opera.com

[commit-bot: I haz the power, 2014-05-02 11:11:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001

[commit-bot: I haz the power, 2014-05-02 11:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 11:46:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium

[João Eiras, 2014-05-02 11:49:36]

The CQ bit was checked by joaoe@opera.com

[commit-bot: I haz the power, 2014-05-02 11:50:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001

[João Eiras, 2014-05-02 12:15:24]

The CQ bit was checked by joaoe@opera.com

[commit-bot: I haz the power, 2014-05-02 12:15:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/joaoe@opera.com/222323002/20001

[commit-bot: I haz the power, 2014-05-02 16:50:10]

Change committed as 267815